You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2013/10/14 20:49:53 UTC
Re: Review Request 14384: Integrated Registrar into Mesos.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14384/#review26977
-----------------------------------------------------------
Ship it!
Thanks! Would be nice to see an in-memory ZK registrar supported by the Cluster abstraction, but giving a ship it regardless.
src/local/local.cpp
<https://reviews.apache.org/r/14384/#comment52536>
"unimplemented for local runs" ?
src/master/flags.hpp
<https://reviews.apache.org/r/14384/#comment52542>
We should make all of these help strings end with periods, no?
src/master/main.cpp
<https://reviews.apache.org/r/14384/#comment52538>
Whoa, this should disallow using leveldb if a zk string was specified, so that we only use leveldb when the master is on one machine, right?
Also, were you planning on getting this TODO for implementing the ZK registry initialization or leaving that for me?
src/tests/cluster.hpp
<https://reviews.apache.org/r/14384/#comment52540>
Can you make this a TODO for me to implement the ZK registry initialization here, if you're not planning on getting to it in this review?
src/tests/cluster.hpp
<https://reviews.apache.org/r/14384/#comment52541>
Ditto
- Ben Mahler
On Sept. 28, 2013, 1:28 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14384/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2013, 1:28 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/local/local.cpp e4b5ec5b3dfae6dd89746353d3caaa8d7e117840
> src/master/flags.hpp d59e67d5b2799d6d7a37e9cfe7246ae7372091ac
> src/master/main.cpp 19fcb9f09d8fc03a0719aada7d216b575eb3069b
> src/master/master.hpp bd5cb1ff05967518d7dc7f3a9dc0d32c22eb9643
> src/master/master.cpp a49b17ef43fca5b385a89731ca8776a26b61399a
> src/slave/slave.cpp 21b57f98dd11ceecac81e353c1b0058f11dd12b2
> src/tests/cluster.hpp f743bb3251af81fb9d8afd51de4df6efcf289bb9
> src/tests/mesos.cpp 776cb0f13d10b4ae437fe9a3c97dc8b3481290af
> src/tests/slave_recovery_tests.cpp 48b2e6380a9ae688291992f3bf25c3cc473bc808
>
> Diff: https://reviews.apache.org/r/14384/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>
Re: Review Request 14384: Integrated Registrar into Mesos.
Posted by Ben Mahler <be...@gmail.com>.
> On Oct. 14, 2013, 6:49 p.m., Ben Mahler wrote:
> > Thanks! Would be nice to see an in-memory ZK registrar supported by the Cluster abstraction, but giving a ship it regardless.
Committed, can you mark as submitted? I'll take up the comments in a subsequent review.
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14384/#review26977
-----------------------------------------------------------
On Sept. 28, 2013, 1:28 a.m., Benjamin Hindman wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14384/
> -----------------------------------------------------------
>
> (Updated Sept. 28, 2013, 1:28 a.m.)
>
>
> Review request for mesos, Ben Mahler and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/local/local.cpp e4b5ec5b3dfae6dd89746353d3caaa8d7e117840
> src/master/flags.hpp d59e67d5b2799d6d7a37e9cfe7246ae7372091ac
> src/master/main.cpp 19fcb9f09d8fc03a0719aada7d216b575eb3069b
> src/master/master.hpp bd5cb1ff05967518d7dc7f3a9dc0d32c22eb9643
> src/master/master.cpp a49b17ef43fca5b385a89731ca8776a26b61399a
> src/slave/slave.cpp 21b57f98dd11ceecac81e353c1b0058f11dd12b2
> src/tests/cluster.hpp f743bb3251af81fb9d8afd51de4df6efcf289bb9
> src/tests/mesos.cpp 776cb0f13d10b4ae437fe9a3c97dc8b3481290af
> src/tests/slave_recovery_tests.cpp 48b2e6380a9ae688291992f3bf25c3cc473bc808
>
> Diff: https://reviews.apache.org/r/14384/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Benjamin Hindman
>
>