You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@annotator.apache.org by GitBox <gi...@apache.org> on 2020/03/30 14:42:40 UTC
[GitHub] [incubator-annotator-website] BigBlueHat opened a new issue #14:
Cleaning up post demo integration
BigBlueHat opened a new issue #14: Cleaning up post demo integration
URL: https://github.com/apache/incubator-annotator-website/issues/14
When I run `yarn install` in the root of the repo it now creations an empty `node_modules/` file and an (essentially) empty `yarn.lock` file:
```yaml
# THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY.
# yarn lockfile v1
```
So, how should we clean these up? `.gitignore` seems like a bad idea for `yarn.lock` (should we ever need to commit it) and magically deleting them during the `yarn install` run also seems like it'd throw off future developers.
ðŸ’'s?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator-website] Treora closed issue #14: Cleaning up
post demo integration
Posted by GitBox <gi...@apache.org>.
Treora closed issue #14: Cleaning up post demo integration
URL: https://github.com/apache/incubator-annotator-website/issues/14
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-annotator-website] Treora commented on issue #14:
Cleaning up post demo integration
Posted by GitBox <gi...@apache.org>.
Treora commented on issue #14: Cleaning up post demo integration
URL: https://github.com/apache/incubator-annotator-website/issues/14#issuecomment-606050102
Oh, apparently I was using an older version of yarn, that does not
create yarn.lock nor node_modules when there are no dependencies.
I just updated yarn and committed the empty lock-file, seems the best
solution to me. And a .gitignore for node_modules, also created (empty).
We could instead have told people to run yarn in the submodule instead,
but quite likely we will have some dependencies at some moment anyway
(e.g. a static site generator to add headers and footers to every page).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services