You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/17 11:10:07 UTC
[GitHub] [superset] dpgaspar opened a new pull request, #22753: chore: re add upload tests
dpgaspar opened a new pull request, #22753:
URL: https://github.com/apache/superset/pull/22753
<!---
Please write the PR title following the conventions at https://www.conventionalcommits.org/en/v1.0.0/
Example:
fix(dashboard): load charts correctly
-->
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] dpgaspar merged pull request #22753: chore: re add upload tests
Posted by GitBox <gi...@apache.org>.
dpgaspar merged PR #22753:
URL: https://github.com/apache/superset/pull/22753
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #22753: chore: re add upload tests
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #22753:
URL: https://github.com/apache/superset/pull/22753#issuecomment-1385272067
# [Codecov](https://codecov.io/gh/apache/superset/pull/22753?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#22753](https://codecov.io/gh/apache/superset/pull/22753?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4525f20) into [master](https://codecov.io/gh/apache/superset/commit/6d37e66cd13053a9175d8ca8f114cbd145e374b2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6d37e66) will **decrease** coverage by `11.37%`.
> The diff coverage is `16.48%`.
> :exclamation: Current head 4525f20 differs from pull request most recent head 4620958. Consider uploading reports for the commit 4620958 to get more accurate results
```diff
@@ Coverage Diff @@
## master #22753 +/- ##
===========================================
- Coverage 67.13% 55.75% -11.38%
===========================================
Files 1869 1876 +7
Lines 71656 71812 +156
Branches 7822 7863 +41
===========================================
- Hits 48103 40042 -8061
- Misses 21526 29744 +8218
+ Partials 2027 2026 -1
```
| Flag | Coverage Δ | |
|---|---|---|
| hive | `?` | |
| mysql | `?` | |
| postgres | `?` | |
| presto | `52.49% <ø> (ø)` | |
| python | `57.94% <ø> (-23.42%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `51.54% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/22753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...gin-chart-echarts/src/Sunburst/EchartsSunburst.tsx](https://codecov.io/gh/apache/superset/pull/22753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvU3VuYnVyc3QvRWNoYXJ0c1N1bmJ1cnN0LnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...ns/plugin-chart-echarts/src/Sunburst/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/22753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvU3VuYnVyc3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (ø)` | |
| [...plugins/plugin-chart-echarts/src/Sunburst/index.ts](https://codecov.io/gh/apache/superset/pull/22753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvU3VuYnVyc3QvaW5kZXgudHM=) | `0.00% <0.00%> (ø)` | |
| [...lugin-chart-echarts/src/Sunburst/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvU3VuYnVyc3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (ø)` | |
| [...gins/plugin-chart-echarts/src/Treemap/constants.ts](https://codecov.io/gh/apache/superset/pull/22753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVHJlZW1hcC9jb25zdGFudHMudHM=) | `54.54% <ø> (ø)` | |
| [.../plugins/plugin-chart-echarts/src/Treemap/types.ts](https://codecov.io/gh/apache/superset/pull/22753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVHJlZW1hcC90eXBlcy50cw==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/GlobalStyles.tsx](https://codecov.io/gh/apache/superset/pull/22753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL0dsb2JhbFN0eWxlcy50c3g=) | `0.00% <ø> (ø)` | |
| [superset-frontend/src/components/Modal/Modal.tsx](https://codecov.io/gh/apache/superset/pull/22753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTW9kYWwvTW9kYWwudHN4) | `85.89% <25.00%> (-3.30%)` | :arrow_down: |
| [...plugin-chart-echarts/src/Sunburst/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/22753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvU3VuYnVyc3QvY29udHJvbFBhbmVsLnRzeA==) | `28.57% <28.57%> (ø)` | |
| [...plugin-chart-echarts/src/Treemap/transformProps.ts](https://codecov.io/gh/apache/superset/pull/22753?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtZWNoYXJ0cy9zcmMvVHJlZW1hcC90cmFuc2Zvcm1Qcm9wcy50cw==) | `50.87% <75.00%> (-1.37%)` | :arrow_down: |
| ... and [303 more](https://codecov.io/gh/apache/superset/pull/22753?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org