You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2020/12/16 09:27:39 UTC

[GitHub] [nifi-minifi-cpp] hunyadi-dev commented on a change in pull request #893: MINIFICPP-1288 - FlowController C2 init refactor

hunyadi-dev commented on a change in pull request #893:
URL: https://github.com/apache/nifi-minifi-cpp/pull/893#discussion_r544141796



##########
File path: libminifi/src/FlowController.cpp
##########
@@ -216,9 +215,6 @@ bool FlowController::applyConfiguration(const std::string &source, const std::st
   bool started = false;
   try {
     load(this->root_, true);
-    flow_update_ = true;
-    started = start() == 0;

Review comment:
       Honestly, I don't remember what was exactly extracted into this PR. I think this was opened to ease the review load on #890, but the boundaries are probably not correctly set. Closing this PR.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org