You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2020/07/22 19:47:30 UTC

[GitHub] [phoenix] gokceni opened a new pull request #839: PHOENIX-5986 Fix flapping test

gokceni opened a new pull request #839:
URL: https://github.com/apache/phoenix/pull/839


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix] gokceni closed pull request #839: PHOENIX-5986 Fix flapping test

Posted by GitBox <gi...@apache.org>.
gokceni closed pull request #839:
URL: https://github.com/apache/phoenix/pull/839


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix] gokceni commented on pull request #839: PHOENIX-5986 Fix flapping test

Posted by GitBox <gi...@apache.org>.
gokceni commented on pull request #839:
URL: https://github.com/apache/phoenix/pull/839#issuecomment-663759564


   Merged


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix] kadirozde commented on a change in pull request #839: PHOENIX-5986 Fix flapping test

Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #839:
URL: https://github.com/apache/phoenix/pull/839#discussion_r459109140



##########
File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexRebuildTaskIT.java
##########
@@ -178,11 +178,15 @@ public static void waitForTaskState(Connection conn, PTable.TaskType taskType, S
         String taskData = "";
         do {
             Thread.sleep(2000);
-            ResultSet rs = conn.createStatement().executeQuery("SELECT * " +
+            String stmt = "SELECT * " +
                     " FROM " + PhoenixDatabaseMetaData.SYSTEM_TASK_NAME +
-                    " WHERE " + PhoenixDatabaseMetaData.TABLE_NAME + "='" + expectedTableName + "' AND " +

Review comment:
       Let's keep the table name in the query. When the task table is used for other use cases, there might be other entries from some other tables in the task table even during this IT




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix] kadirozde commented on pull request #839: PHOENIX-5986 Fix flapping test

Posted by GitBox <gi...@apache.org>.
kadirozde commented on pull request #839:
URL: https://github.com/apache/phoenix/pull/839#issuecomment-662696425


   
   
   
   
   > The issue was that the task was still running when we do syscat query in the test @kadirozde
   @gokceni, I think the issue here is that we call TaskRegionObserver.run() within the IT while TaskRegionObserver is scheduled to run periodically. In some cases, the tasks are picked up by the periodic execution and in other cases by the direct call from the IT. This causes a race between these two different execution mode. So, the right solution is to disable the periodic runs in this IT to eliminate this race.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix] kadirozde commented on a change in pull request #839: PHOENIX-5986 Fix flapping test

Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #839:
URL: https://github.com/apache/phoenix/pull/839#discussion_r459110733



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/tasks/DropChildViewsTask.java
##########
@@ -46,6 +46,7 @@
     public TaskRegionObserver.TaskResult run(Task.TaskRecord taskRecord) {
         PhoenixConnection pconn = null;
         Timestamp timestamp = taskRecord.getTimeStamp();
+        LOGGER.info("DropChildViewTask is running for task " + taskRecord.getTableName());

Review comment:
       This was suggested for only debugging. Let's remove it or use LOGGER.debug() instead




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix] gokceni commented on pull request #839: PHOENIX-5986 Fix flapping test

Posted by GitBox <gi...@apache.org>.
gokceni commented on pull request #839:
URL: https://github.com/apache/phoenix/pull/839#issuecomment-662660060


   The issue was that the task was still running when we do syscat query in the test @kadirozde 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix] kadirozde edited a comment on pull request #839: PHOENIX-5986 Fix flapping test

Posted by GitBox <gi...@apache.org>.
kadirozde edited a comment on pull request #839:
URL: https://github.com/apache/phoenix/pull/839#issuecomment-662696425


   
   
   
   > The issue was that the task was still running when we do syscat query in the test @kadirozde
   @gokceni, I think the issue here is that we call TaskRegionObserver.run() within the IT while TaskRegionObserver is scheduled to run periodically. In some cases, the tasks are picked up by the periodic execution and in other cases by the direct call from the IT. This causes a race between these two different execution modes. So, the right solution is to disable the periodic runs in this IT to eliminate this race.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [phoenix] kadirozde commented on a change in pull request #839: PHOENIX-5986 Fix flapping test

Posted by GitBox <gi...@apache.org>.
kadirozde commented on a change in pull request #839:
URL: https://github.com/apache/phoenix/pull/839#discussion_r459111218



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/tasks/DropChildViewsTask.java
##########
@@ -46,6 +46,7 @@
     public TaskRegionObserver.TaskResult run(Task.TaskRecord taskRecord) {
         PhoenixConnection pconn = null;
         Timestamp timestamp = taskRecord.getTimeStamp();
+        LOGGER.info("DropChildViewTask is running for task " + taskRecord.getTableName());

Review comment:
       And the same comment for the other instances of LOGGER.info




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org