You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Thejas Nair <th...@hortonworks.com> on 2015/02/03 20:26:26 UTC
Review Request 30575: HIVE-9350 : Add ability for HiveAuthorizer
implementations to filter out results of 'show tables', 'show databases'
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30575/
-----------------------------------------------------------
Review request for hive and Jason Dere.
Bugs: HIVE-9350
https://issues.apache.org/jira/browse/HIVE-9350
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-9350
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6d2748e
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java cceac93
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/DefaultMetaStoreFilterHookImpl.java b723484
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java 51f63ad
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessControlException.java d877686
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 5a5b3d5
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 1f1eba2
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java e615049
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java ac1cc47
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java cabc22a
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 0e093b0
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java d81b44c
service/src/java/org/apache/hive/service/cli/CLIService.java 883bf9b
service/src/java/org/apache/hive/service/cli/session/SessionManager.java 8ade297
Diff: https://reviews.apache.org/r/30575/diff/
Testing
-------
New unit tests.
Thanks,
Thejas Nair
Re: Review Request 30575: HIVE-9350 : Add ability for HiveAuthorizer
implementations to filter out results of 'show tables',
'show databases'
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30575/
-----------------------------------------------------------
(Updated Feb. 13, 2015, 7 p.m.)
Review request for hive and Jason Dere.
Changes
-------
Fix the classnotfound exception at runtime from perflogger.
Bugs: HIVE-9350
https://issues.apache.org/jira/browse/HIVE-9350
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-9350
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 90bcc49
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java cceac93
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/DefaultMetaStoreFilterHookImpl.java b723484
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java 51f63ad
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessControlException.java d877686
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 5a5b3d5
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 1f1eba2
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java e615049
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java ac1cc47
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java cabc22a
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 0e093b0
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java d4e5562
service/src/java/org/apache/hive/service/cli/CLIService.java 883bf9b
Diff: https://reviews.apache.org/r/30575/diff/
Testing
-------
New unit tests.
Thanks,
Thejas Nair
Re: Review Request 30575: HIVE-9350 : Add ability for HiveAuthorizer
implementations to filter out results of 'show tables',
'show databases'
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30575/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 1:30 a.m.)
Review request for hive and Jason Dere.
Changes
-------
HIVE-9350.4.patch - addressing review comments from Jason
Bugs: HIVE-9350
https://issues.apache.org/jira/browse/HIVE-9350
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-9350
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6d2748e
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java cceac93
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/DefaultMetaStoreFilterHookImpl.java b723484
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java 51f63ad
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessControlException.java d877686
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 5a5b3d5
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 1f1eba2
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java e615049
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java ac1cc47
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java cabc22a
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 0e093b0
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java d81b44c
service/src/java/org/apache/hive/service/cli/CLIService.java 883bf9b
Diff: https://reviews.apache.org/r/30575/diff/
Testing
-------
New unit tests.
Thanks,
Thejas Nair
Re: Review Request 30575: HIVE-9350 : Add ability for HiveAuthorizer
implementations to filter out results of 'show tables',
'show databases'
Posted by Thejas Nair <th...@hortonworks.com>.
> On Feb. 4, 2015, 12:15 a.m., Jason Dere wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java, line 710
> > <https://reviews.apache.org/r/30575/diff/2/?file=846469#file846469line710>
> >
> > Perhaps mention in a comment that this should only be called for V2 authorization, or maybe add a check at the top of the method to return if !isAuthorizationModeV2()
Will change the method name to indicate that its only for V2. Also updated comment in location where its called to state that its processing V2 authorizer.
- Thejas
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30575/#review70871
-----------------------------------------------------------
On Feb. 3, 2015, 7:27 p.m., Thejas Nair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30575/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 7:27 p.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-9350
> https://issues.apache.org/jira/browse/HIVE-9350
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-9350
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6d2748e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java cceac93
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/DefaultMetaStoreFilterHookImpl.java b723484
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java 51f63ad
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessControlException.java d877686
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 5a5b3d5
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 1f1eba2
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java e615049
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java ac1cc47
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java cabc22a
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 0e093b0
> ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java d81b44c
> service/src/java/org/apache/hive/service/cli/CLIService.java 883bf9b
>
> Diff: https://reviews.apache.org/r/30575/diff/
>
>
> Testing
> -------
>
> New unit tests.
>
>
> Thanks,
>
> Thejas Nair
>
>
Re: Review Request 30575: HIVE-9350 : Add ability for HiveAuthorizer
implementations to filter out results of 'show tables',
'show databases'
Posted by Jason Dere <jd...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30575/#review70871
-----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java
<https://reviews.apache.org/r/30575/#comment116321>
Perhaps mention in a comment that this should only be called for V2 authorization, or maybe add a check at the top of the method to return if !isAuthorizationModeV2()
- Jason Dere
On Feb. 3, 2015, 7:27 p.m., Thejas Nair wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/30575/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2015, 7:27 p.m.)
>
>
> Review request for hive and Jason Dere.
>
>
> Bugs: HIVE-9350
> https://issues.apache.org/jira/browse/HIVE-9350
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> https://issues.apache.org/jira/browse/HIVE-9350
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6d2748e
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java cceac93
> itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java PRE-CREATION
> metastore/src/java/org/apache/hadoop/hive/metastore/DefaultMetaStoreFilterHookImpl.java b723484
> metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java 51f63ad
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java PRE-CREATION
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessControlException.java d877686
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 5a5b3d5
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 1f1eba2
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java e615049
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java ac1cc47
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java cabc22a
> ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 0e093b0
> ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java d81b44c
> service/src/java/org/apache/hive/service/cli/CLIService.java 883bf9b
>
> Diff: https://reviews.apache.org/r/30575/diff/
>
>
> Testing
> -------
>
> New unit tests.
>
>
> Thanks,
>
> Thejas Nair
>
>
Re: Review Request 30575: HIVE-9350 : Add ability for HiveAuthorizer
implementations to filter out results of 'show tables',
'show databases'
Posted by Thejas Nair <th...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30575/
-----------------------------------------------------------
(Updated Feb. 3, 2015, 7:27 p.m.)
Review request for hive and Jason Dere.
Changes
-------
HIVE-9350.3.patch - remove unnecessary import that was added in patch from SessionManager
Bugs: HIVE-9350
https://issues.apache.org/jira/browse/HIVE-9350
Repository: hive-git
Description
-------
https://issues.apache.org/jira/browse/HIVE-9350
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6d2748e
itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestFilterHooks.java cceac93
itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/security/authorization/plugin/TestHiveAuthorizerShowFilters.java PRE-CREATION
metastore/src/java/org/apache/hadoop/hive/metastore/DefaultMetaStoreFilterHookImpl.java b723484
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreFilterHook.java 51f63ad
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/AuthorizationMetaStoreFilterHook.java PRE-CREATION
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAccessControlException.java d877686
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizationValidator.java 5a5b3d5
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizer.java 1f1eba2
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveAuthorizerImpl.java e615049
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/HiveV1Authorizer.java ac1cc47
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/DummyHiveAuthorizationValidator.java cabc22a
ql/src/java/org/apache/hadoop/hive/ql/security/authorization/plugin/sqlstd/SQLStdHiveAuthorizationValidator.java 0e093b0
ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java d81b44c
service/src/java/org/apache/hive/service/cli/CLIService.java 883bf9b
Diff: https://reviews.apache.org/r/30575/diff/
Testing
-------
New unit tests.
Thanks,
Thejas Nair