You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@echarts.apache.org by GitBox <gi...@apache.org> on 2022/12/24 10:36:48 UTC

[GitHub] [echarts] huangyulie commented on a diff in pull request #18100: feat[gauge]: add formatter in array form

huangyulie commented on code in PR #18100:
URL: https://github.com/apache/echarts/pull/18100#discussion_r1056793229


##########
src/chart/gauge/GaugeView.ts:
##########
@@ -674,7 +674,10 @@ class GaugeView extends ChartView {
                     seriesModel.get(['progress', 'show']) ? data.getItemVisual(idx, 'style').fill : autoColor
                 ) as string;
                 const labelEl = newDetailEls[idx];
-                const formatter = itemDetailModel.get('formatter');
+                let formatter = itemDetailModel.get('formatter');
+                if (isArray(formatter)) {

Review Comment:
   oh~i get it ,thank you!I'm just trying to solve this [issue#18021](https://github.com/apache/echarts/issues/18021)🤣



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org