[jira] (HBASE-27058) Admin#getLastMajorCompactionTimestamp() doesn't get updated when the EnvironmentEdgeManager clock is stopped

["Andrew Kyle Purtell (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-27058 ]


    Andrew Kyle Purtell deleted comment on HBASE-27058:
    ---------------------------------------------

was (Author: apurtell):
There may be a simple solution available to restore the expected behavior with a simple assignment. Let me look into it.

> Admin#getLastMajorCompactionTimestamp() doesn't get updated when the EnvironmentEdgeManager clock is stopped
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-27058
>                 URL: https://issues.apache.org/jira/browse/HBASE-27058
>             Project: HBase
>          Issue Type: Bug
>    Affects Versions: 2.5.0
>            Reporter: Istvan Toth
>            Assignee: Andrew Kyle Purtell
>            Priority: Major
>              Labels: test
>
> In Hbase 2.0-2.4 it is possible to check for a finished compaction by polling 
> Admin.getLastMajorCompactionTimestamp() for the table under compaction, even when the clock is stopped via EnvironmentEdgeManager.
> However, in Hbase 2.5 the Admin.getLastMajorCompactionTimestamp() will not be updated even after the compaction is finished, and getCompactionState() returns NONE.
> I am not even sure that this is bug, however, this has broken one of our Phoenix tests, and may cause problems for others.
> This is the test code that breaks:
> [https://github.com/apache/phoenix/blob/8aa825ed88828a99d40fdb68eb2f930981cd8a6b/phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java#L818]
> Admin.getLastMajorCompactionTimestamp() seems to take the value from the Metrics, so I guess that the metrics no longer get updated somewhere when the clock is stopped.
> I did not dig deeper than that.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)