You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@subversion.apache.org by rh...@apache.org on 2012/12/19 17:00:51 UTC

svn commit: r1423910 - /subversion/trunk/subversion/svn/copy-cmd.c

Author: rhuijben
Date: Wed Dec 19 16:00:51 2012
New Revision: 1423910

URL: http://svn.apache.org/viewvc?rev=1423910&view=rev
Log:
* subversion/svn/copy-cmd.c
  (svn_cl__copy): Following up on r1423887, don't leak other error types.

Modified:
    subversion/trunk/subversion/svn/copy-cmd.c

Modified: subversion/trunk/subversion/svn/copy-cmd.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/copy-cmd.c?rev=1423910&r1=1423909&r2=1423910&view=diff
==============================================================================
--- subversion/trunk/subversion/svn/copy-cmd.c (original)
+++ subversion/trunk/subversion/svn/copy-cmd.c Wed Dec 19 16:00:51 2012
@@ -70,7 +70,7 @@ svn_cl__copy(apr_getopt_t *os,
 
       err = svn_opt_parse_path(peg_revision, &src, target, pool);
 
-      if (err && err->apr_err == SVN_ERR_BAD_FILENAME)
+      if (err)
         {
           /* Issue #3606: 'svn cp .@HEAD target' gives
              svn: '@HEAD' is just a peg revision. Maybe try '@HEAD@' instead? 
@@ -79,7 +79,7 @@ svn_cl__copy(apr_getopt_t *os,
              svn_cl__args_to_target_array_print_reserved(). Undo that in an
              attempt to fix this issue without revving many apis.
            */
-          if (*target == '@')
+          if (*target == '@' && err->apr_err == SVN_ERR_BAD_FILENAME)
             {
               svn_error_t *err2;