You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joerg Schad <jo...@mesosphere.io> on 2015/06/08 18:22:19 UTC

Re: Review Request 35206: Added mainpage to doxygen documentation.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35206/
-----------------------------------------------------------

(Updated June 8, 2015, 4:22 p.m.)


Review request for mesos and Bernd Mathiske.


Changes
-------

Addressed comments


Bugs: Mesos-2500
    https://issues.apache.org/jira/browse/Mesos-2500


Repository: mesos


Description
-------

Added mainpage to doxygen documentation.


Diffs (updated)
-----

  Doxyfile cdc4c12b33a6182ba5f1226b87a47ca491ee5174 
  src/main.dox PRE-CREATION 

Diff: https://reviews.apache.org/r/35206/diff/


Testing
-------


Thanks,

Joerg Schad

Re: Review Request 35206: Added mainpage to doxygen documentation.

Posted by Bernd Mathiske <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35206/#review87045
-----------------------------------------------------------

Ship it!


Ship It!

- Bernd Mathiske


On June 8, 2015, 9:22 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35206/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 9:22 a.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: Mesos-2500
>     https://issues.apache.org/jira/browse/Mesos-2500
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added mainpage to doxygen documentation.
> 
> 
> Diffs
> -----
> 
>   Doxyfile cdc4c12b33a6182ba5f1226b87a47ca491ee5174 
>   src/main.dox PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35206/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 35206: Added mainpage to doxygen documentation.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35206/#review87044
-----------------------------------------------------------


Bad patch!

Reviews applied: [35206]

Failed command: ./support/apply-review.sh -n -r 35206

Error:
 2015-06-08 16:25:48 URL:https://reviews.apache.org/r/35206/diff/raw/ [1803/1803] -> "35206.patch" [1]
35206.patch:42: new blank line at EOF.
+
warning: 1 line adds whitespace errors.
Successfully applied: Added mainpage to doxygen documentation.

Added mainpage to doxygen documentation.


Review: https://reviews.apache.org/r/35206
src/main.dox:13: new blank line at EOF.
Failed to commit patch

- Mesos ReviewBot


On June 8, 2015, 4:22 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35206/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 4:22 p.m.)
> 
> 
> Review request for mesos and Bernd Mathiske.
> 
> 
> Bugs: Mesos-2500
>     https://issues.apache.org/jira/browse/Mesos-2500
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added mainpage to doxygen documentation.
> 
> 
> Diffs
> -----
> 
>   Doxyfile cdc4c12b33a6182ba5f1226b87a47ca491ee5174 
>   src/main.dox PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35206/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 35206: Added mainpage to doxygen documentation.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35206/#review87093
-----------------------------------------------------------


Patch looks great!

Reviews applied: [35206]

All tests passed.

- Mesos ReviewBot


On June 8, 2015, 8:51 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35206/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 8:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
> 
> 
> Bugs: Mesos-2500
>     https://issues.apache.org/jira/browse/Mesos-2500
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added mainpage to doxygen documentation.
> 
> 
> Diffs
> -----
> 
>   Doxyfile cdc4c12b33a6182ba5f1226b87a47ca491ee5174 
>   src/main.dox PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35206/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 35206: Added mainpage to doxygen documentation.

Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35206/#review87153
-----------------------------------------------------------

Ship it!


Ship It!

- Benjamin Hindman


On June 8, 2015, 8:51 p.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35206/
> -----------------------------------------------------------
> 
> (Updated June 8, 2015, 8:51 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Bernd Mathiske.
> 
> 
> Bugs: Mesos-2500
>     https://issues.apache.org/jira/browse/Mesos-2500
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added mainpage to doxygen documentation.
> 
> 
> Diffs
> -----
> 
>   Doxyfile cdc4c12b33a6182ba5f1226b87a47ca491ee5174 
>   src/main.dox PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/35206/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 35206: Added mainpage to doxygen documentation.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35206/
-----------------------------------------------------------

(Updated June 8, 2015, 8:51 p.m.)


Review request for mesos, Benjamin Hindman and Bernd Mathiske.


Bugs: Mesos-2500
    https://issues.apache.org/jira/browse/Mesos-2500


Repository: mesos


Description
-------

Added mainpage to doxygen documentation.


Diffs
-----

  Doxyfile cdc4c12b33a6182ba5f1226b87a47ca491ee5174 
  src/main.dox PRE-CREATION 

Diff: https://reviews.apache.org/r/35206/diff/


Testing
-------


Thanks,

Joerg Schad

Re: Review Request 35206: Added mainpage to doxygen documentation.

Posted by Joerg Schad <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35206/
-----------------------------------------------------------

(Updated June 8, 2015, 8:42 p.m.)


Review request for Benjamin Hindman and Bernd Mathiske.


Bugs: Mesos-2500
    https://issues.apache.org/jira/browse/Mesos-2500


Repository: mesos


Description
-------

Added mainpage to doxygen documentation.


Diffs (updated)
-----

  Doxyfile cdc4c12b33a6182ba5f1226b87a47ca491ee5174 
  src/main.dox PRE-CREATION 

Diff: https://reviews.apache.org/r/35206/diff/


Testing
-------


Thanks,

Joerg Schad