You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2015/12/01 15:09:28 UTC
Review Request 40821: Quota: Ensured the sorter for quota'ed roles
does not contain revocable resources.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40821/
-----------------------------------------------------------
Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu, and Qian Zhang.
Bugs: MESOS-3718
https://issues.apache.org/jira/browse/MESOS-3718
Repository: mesos
Description
-------
See summary.
Diffs
-----
src/master/allocator/mesos/hierarchical.hpp 1cd8d16661568010901e74705375e7719cdfb8a0
src/master/allocator/mesos/hierarchical.cpp b8f3be8e65f9be68a78c61a958903d3e36910efb
Diff: https://reviews.apache.org/r/40821/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40821: Quota: Ensured the sorter for quota'ed
roles does not contain revocable resources.
Posted by Joris Van Remoortere <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40821/#review109003
-----------------------------------------------------------
Ship it!
Ship It!
- Joris Van Remoortere
On Dec. 4, 2015, 10:09 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40821/
> -----------------------------------------------------------
>
> (Updated Dec. 4, 2015, 10:09 a.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu, and Qian Zhang.
>
>
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 388ed1775b03cef3f5ea41e2ee17a752e834527d
> src/master/allocator/mesos/hierarchical.cpp 6d82ae7be28ad0dba35941114bafb05b7540ebd1
>
> Diff: https://reviews.apache.org/r/40821/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 40821: Quota: Ensured the sorter for quota'ed
roles does not contain revocable resources.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40821/
-----------------------------------------------------------
(Updated Dec. 4, 2015, 10:09 a.m.)
Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu, and Qian Zhang.
Changes
-------
Rebased.
Bugs: MESOS-3718
https://issues.apache.org/jira/browse/MESOS-3718
Repository: mesos
Description
-------
See summary.
Diffs (updated)
-----
src/master/allocator/mesos/hierarchical.hpp 388ed1775b03cef3f5ea41e2ee17a752e834527d
src/master/allocator/mesos/hierarchical.cpp 6d82ae7be28ad0dba35941114bafb05b7540ebd1
Diff: https://reviews.apache.org/r/40821/diff/
Testing
-------
make check (Mac OS X 10.10.4)
Thanks,
Alexander Rukletsov
Re: Review Request 40821: Quota: Ensured the sorter for quota'ed
roles does not contain revocable resources.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40821/#review108546
-----------------------------------------------------------
Patch looks great!
Reviews applied: [40586, 40551, 40332, 40795, 39450, 40797, 40821]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Dec. 1, 2015, 2:09 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40821/
> -----------------------------------------------------------
>
> (Updated Dec. 1, 2015, 2:09 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Joerg Schad, Joris Van Remoortere, Joseph Wu, and Qian Zhang.
>
>
> Bugs: MESOS-3718
> https://issues.apache.org/jira/browse/MESOS-3718
>
>
> Repository: mesos
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.hpp 1cd8d16661568010901e74705375e7719cdfb8a0
> src/master/allocator/mesos/hierarchical.cpp b8f3be8e65f9be68a78c61a958903d3e36910efb
>
> Diff: https://reviews.apache.org/r/40821/diff/
>
>
> Testing
> -------
>
> make check (Mac OS X 10.10.4)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>