You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/06/07 07:11:27 UTC
[GitHub] [incubator-nuttx] adamkaliszan opened a new pull request, #6378: SSD1680 e-ink driver
adamkaliszan opened a new pull request, #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378
## Summary
E-Ink display SSD1680 support
## Impact
Supports new E-INK driver with 4 wire SPI interface.
Lilygo t5v2 board support package.
## Testing
Tested on EPS32 TTGO t5v2 with mono 2.9 e-ink display
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamkaliszan commented on pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
adamkaliszan commented on PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#issuecomment-1152086897
I will split this pull request int two parts: driver and BSP.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#issuecomment-1151427580
@adamkaliszan your fb defconfig still incorrect, you need to Normalize it using the refresh.sh script, then you will see that this option was removed:
```
diff --git a/boards/xtensa/esp32/ttgo_eink5_v2/configs/fb/defconfig b/boards/xtensa/esp32/ttgo_eink5_v2/configs/fb/defconfig
index b4ef353f11..4eaa7f56d7 100644
--- a/boards/xtensa/esp32/ttgo_eink5_v2/configs/fb/defconfig
+++ b/boards/xtensa/esp32/ttgo_eink5_v2/configs/fb/defconfig
@@ -31,7 +31,6 @@ CONFIG_IDLETHREAD_STACKSIZE=3072
CONFIG_INIT_ENTRYPOINT="nsh_main"
CONFIG_INTELHEX_BINARY=y
CONFIG_LCD_PORTRAIT=y
-CONFIG_LCD_SSD1680_2_9=y
CONFIG_MM_REGIONS=3
CONFIG_NSH_ARCHINIT=y
CONFIG_NSH_BUILTIN_APPS=y
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#discussion_r891248926
##########
boards/Kconfig:
##########
@@ -2434,13 +2436,14 @@ config ARCH_BOARD
default "emw3162" if ARCH_BOARD_EMW3162
default "quickfeather" if ARCH_BOARD_QUICKFEATHER
default "esp32-devkitc" if ARCH_BOARD_ESP32_DEVKITC
+ default "ttgo_lora_esp32" if ARCH_BOARD_TTGO_LORA_ESP32
Review Comment:
@adamkaliszan the ttgo_lora_esp32 is already in the mainline, for some reason this patch it adding it again, please double check this issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#issuecomment-1149308526
@adamkaliszan seams there is an issue in the netnsh:
```
Configuration/Tool: ttgo_eink5_v2/netnsh
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Building NuttX...
src/esp32_ssd1680.c: In function 'board_lcd_initialize':
Error: src/esp32_ssd1680.c:137:9: error: implicit declaration of function 'esp32_spibus_initialize'; did you mean 'esp32_gpioirqinitialize'? [-Werror=implicit-function-declaration]
spi = esp32_spibus_initialize(CONFIG_SSD1680_SPI_BUS);
^~~~~~~~~~~~~~~~~~~~~~~
esp32_gpioirqinitialize
Error: src/esp32_ssd1680.c:137:7: error: assignment to 'struct spi_dev_s *' from 'int' makes pointer from integer without a cast [-Werror=int-conversion]
spi = esp32_spibus_initialize(CONFIG_SSD1680_SPI_BUS);
^
cc1: all warnings being treated as errors
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#discussion_r891887692
##########
drivers/lcd/Kconfig:
##########
@@ -323,38 +323,6 @@ config LCD_HILETGO
LCD_MAXCONTRAST should be 255, but any value >0 and <=255 will be accepted.
LCD_MAXPOWER should be 1: 0=off, 1=on
-config LCD_SSD1306_CUSTOM
Review Comment:
why delete the custom section of ssd1306?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamkaliszan commented on a diff in pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
adamkaliszan commented on code in PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#discussion_r890947144
##########
boards/xtensa/esp32/ttgo_eink5_v2/compile_commands.json:
##########
@@ -0,0 +1 @@
+[]
Review Comment:
No, I will remove it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamkaliszan commented on pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
adamkaliszan commented on PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#issuecomment-1148864253
@acassis Thx for Your remarks.
I was wondering if split it into two commits or no. The reason, why I decided to pull all together was testing possibility.
I can split it into two commits. I have some questions
1) Current implementation of driver was not tested on 3 color displays. Portrait mode with 3 colors should work. Landscape mode with 3 colors is not implemented (more complicated bit stripping). I decided to add #error macro in order to inform that some modes are not implemented.
What should I do with the code for 3 color displays. Remove it or leave in current state? Maybe I should remove options with 3 color displays in Kconfig file?
2) Using E-Ink display has a little bit different philosophy in comparison to LCD or OLED. There is special command that redraw the screen. This operation is time consuming (about 1s) and energy consuming. Now display redraw content after changing the last row. I would like to add special IOCLT command or use the existing one, that as argument takes area. Area with width and height 0 determine, that we want to redraw screen. I didn't want to add driver that have an impact on using frame buffer. Is it acceptable in first version?
3) Missing library for coping bits, like memcopy for coping the bytes. Now special functions are in driver file. Is it acceptable?
4) There are 5 very similar functions ssd1680_snd_cmd_with_data0 .. ssd1680_snd_cmd_with_data4. I wanted to avoid using vargs macros. Is it acceptable or replace it by one function with variable number of arguments?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] CV-Bowen commented on a diff in pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
CV-Bowen commented on code in PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#discussion_r890955859
##########
boards/Kconfig:
##########
@@ -225,12 +225,6 @@ config ARCH_BOARD_ESP32_DEVKITC
of two CPUs is symmetric, meaning they use the same addresses to
access the same memory.
-config ARCH_BOARD_TLSR8278ADK80D
Review Comment:
Please do not delete other board config.
##########
boards/Kconfig:
##########
@@ -2607,7 +2610,6 @@ config ARCH_BOARD
default "b-g431b-esc1" if ARCH_BOARD_B_G431B_ESC1
default "nucleo-g431kb" if ARCH_BOARD_NUCLEO_G431KB
default "nucleo-g431rb" if ARCH_BOARD_NUCLEO_G431RB
- default "nucleo-g474re" if ARCH_BOARD_NUCLEO_G474RE
Review Comment:
Ditto
##########
boards/Kconfig:
##########
@@ -1965,16 +1977,6 @@ config ARCH_BOARD_NUCLEO_G431RB
---help---
STMicro Nucleo-G431RB board based on the STMicro STM32G431RB MCU.
-config ARCH_BOARD_NUCLEO_G474RE
Review Comment:
Ditto
##########
boards/Kconfig:
##########
@@ -3397,9 +3405,6 @@ endif
if ARCH_BOARD_XX3823
source "boards/sparc/bm3823/xx3823/Kconfig"
endif
-if ARCH_BOARD_TLSR8278ADK80D
Review Comment:
Ditto
##########
boards/Kconfig:
##########
@@ -2434,13 +2436,14 @@ config ARCH_BOARD
default "emw3162" if ARCH_BOARD_EMW3162
default "quickfeather" if ARCH_BOARD_QUICKFEATHER
default "esp32-devkitc" if ARCH_BOARD_ESP32_DEVKITC
+ default "ttgo_lora_esp32" if ARCH_BOARD_TTGO_LORA_ESP32
+ default "ttgo_eink5_v2" if ARCH_BOARD_TTGO_T5V2_ESP32
default "esp32-ethernet-kit" if ARCH_BOARD_ESP32_ETHERNETKIT
default "esp32-wrover-kit" if ARCH_BOARD_ESP32_WROVERKIT
default "esp32c3-devkit" if ARCH_BOARD_ESP32C3_DEVKIT
default "esp32s2-saola-1" if ARCH_BOARD_ESP32S2_SAOLA_1
default "esp32s3-devkit" if ARCH_BOARD_ESP32S3_DEVKIT
default "et-stm32-stamp" if ARCH_BOARD_ET_STM32_STAMP
- default "tlsr8278adk80d" if ARCH_BOARD_TLSR8278ADK80D
Review Comment:
Ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#issuecomment-1149421985
Please normalize your defconfig like this:
```
./tools/refresh.sh --silent ttgo_eink5_v2:fb
```
to fix the following ci fail:
```
HEAD detached at pull/6378/merge
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: boards/xtensa/esp32/ttgo_eink5_v2/configs/fb/defconfig
modified: boards/xtensa/esp32/ttgo_eink5_v2/configs/netnsh/defconfig
modified: boards/xtensa/esp32/ttgo_eink5_v2/configs/nsh/defconfig
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#issuecomment-1148355982
Can you please also rebase on top of the latest master, not sure why the tlsr8278adk80d/nsh is trying to enable custom board configs, the history of the file shows that the defconfig never had those... cc. @xiaoxiang781216
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#issuecomment-1148374347
@CV-Bowen could you take a look why CI report error here:
https://github.com/apache/incubator-nuttx/runs/6769190343?check_suite_focus=true
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamkaliszan closed pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
adamkaliszan closed pull request #6378: SSD1680 e-ink driver
URL: https://github.com/apache/incubator-nuttx/pull/6378
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#issuecomment-1148708586
@adamkaliszan thank you very much for this nice driver!
I think it could be a good idea to create separated commits: first you add the SSD1680 driver, then your new ttgo board and then add board support to SSD1680 in your board. But it is up to you, just a suggestion to make things more easy to review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#discussion_r891954527
##########
boards/xtensa/esp32/common/Kconfig:
##########
@@ -60,6 +60,34 @@ choice ESP32_SPIFLASH_FS
endchoice
+if LCD_SSD1680
+config SSD1680_GPIO_PIN_RST
+ int "Pin that handles the reset line (output)"
+ default "12" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_BUSY
+ int "Pin that handles the busy line (input)"
+ default "4" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_PWR
+ int "Pin that handles the pwr on/off line (output)"
+ default "-1" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_CS
+ int "Pin that select the chip on SPI bus"
+ default "5" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_DTA_CMD
+ int "Pin that switch between command and data on 4-wire SPI bus"
+ default "19" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_SPI_BUS
+ int "Spi bus no"
Review Comment:
@adamkaliszan this comment isn't addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on a diff in pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
acassis commented on code in PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#discussion_r891741104
##########
boards/xtensa/esp32/common/Kconfig:
##########
@@ -60,6 +60,34 @@ choice ESP32_SPIFLASH_FS
endchoice
+if LCD_SSD1680
+config SSD1680_GPIO_PIN_RST
+ int "Pin that handles the reset line (output)"
+ default "12" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_BUSY
+ int "Pin that handles the busy line (input)"
+ default "4" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_PWR
+ int "Pin that handles the pwr on/off line (output)"
+ default "-1" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_CS
+ int "Pin that select the chip on SPI bus"
+ default "5" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_GPIO_PIN_DTA_CMD
+ int "Pin that switch between command and data on 4-wire SPI bus"
+ default "19" if ARCH_BOARD_TTGO_T5V2_ESP32
+
+config SSD1680_SPI_BUS
+ int "Spi bus no"
Review Comment:
```suggestion
int "SPI Bus number"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] adamkaliszan commented on pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
adamkaliszan commented on PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#issuecomment-1152091379
I would like to withdraw this pull request. I have added new pull request with driver only, without BSP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] Ouss4 commented on a diff in pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
Ouss4 commented on code in PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#discussion_r890882550
##########
boards/xtensa/esp32/ttgo_eink5_v2/compile_commands.json:
##########
@@ -0,0 +1 @@
+[]
Review Comment:
Why do we need this file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a diff in pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#discussion_r891303352
##########
boards/Kconfig:
##########
@@ -1399,7 +1417,7 @@ config ARCH_BOARD_NUCLEO_L552ZE
config ARCH_BOARD_QEMU_I486
bool "Qemu i486 Mode"
- depends on ARCH_X86 || ARCH_I486
+ depends on ARCH_CHIP_QEMU_I486
Review Comment:
The same change is merged https://github.com/apache/incubator-nuttx/pull/6374/files#diff-60cc096e3a9b22a769602cbbc3b0f5e7731e72db7b0338da04fcf665ed753b64R1402
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#issuecomment-1151423702
@adamkaliszan CONFIG_LCD_SSD1680_2_9=y is redundant setting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] acassis commented on pull request #6378: SSD1680 e-ink driver
Posted by GitBox <gi...@apache.org>.
acassis commented on PR #6378:
URL: https://github.com/apache/incubator-nuttx/pull/6378#issuecomment-1149205980
> @acassis Thx for Your remarks. I was wondering if split it into two commits or no. The reason, why I decided to pull all together was testing possibility. I can split it into two commits. I have some questions
>
> 1. Current implementation of driver was not tested on 3 color displays. Portrait mode with 3 colors should work. Landscape mode with 3 colors is not implemented (more complicated bit stripping). I decided to add #error macro in order to inform that some modes are not implemented.
> What should I do with the code for 3 color displays. Remove it or leave in current state? Maybe I should remove options with 3 color displays in Kconfig file?
>
> 2. Using E-Ink display has a little bit different philosophy in comparison to LCD or OLED. There is special command that redraw the screen. This operation is time consuming (about 1s) and energy consuming. Now display redraw content after changing the last row. I would like to add special IOCLT command or use the existing one, that as argument takes area. Area with width and height 0 determine, that we want to redraw screen. I didn't want to add driver that have an impact on using frame buffer. Is it acceptable in first version?
>
> 3. Missing library for coping bits, like memcopy for coping the bytes. Now special functions are in driver file. Is it acceptable?
>
> 4. There are 5 very similar functions ssd1680_snd_cmd_with_data0 .. ssd1680_snd_cmd_with_data4. I wanted to avoid using vargs macros. Is it acceptable or replace it by one function with variable number of arguments?
1. You can keep the entry in the Kconfig and just include ("not implemented yet").
2. Maybe you can support two options: an automatic redraw to use it similar to a LCD/OLED, then the last byte of framebuffer is written (last line/last column) is written it do the redraw and the IOCTL option to let user to redraw manually when some area of the display is written.
3. Yes, if you cannot use memcpy or similar, it is okay to have your own implementation.
4. I also thing it is better to have these 5 similar functions than using vargs, but there are some few drivers using vargs. If you decide to go this way, you are not the first one to follow this path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org