You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/15 12:12:35 UTC

[GitHub] [airflow] potiuk commented on pull request #21342: Add 'Show record' option for variables

potiuk commented on pull request #21342:
URL: https://github.com/apache/airflow/pull/21342#issuecomment-1040199987


   Yeah. I think this is indeed risky to have it. I would be against having it in this form - but I think it could be shown with masking. You'd just need to take the "masked" string as source for JSON formatter rather than the value of the variable and convert it back to json. I can't imagine "real" situation where masking would break json structure (It would hve to be a really weird combination of parameter containing a `" }` or similar weird combination (and we always can fall-back to plain string if json formatting fails). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org