[GitHub] [hive] pkumarsinha commented on a diff in pull request #4078: [HIVE-27104] Upgrade Bouncy Castle to 1.68 due to high CVE's

["pkumarsinha (via GitHub)" <gi...@apache.org>]

pkumarsinha commented on code in PR #4078:
URL: https://github.com/apache/hive/pull/4078#discussion_r1122746609


##########
pom.xml:
##########
@@ -883,7 +883,12 @@
       <dependency>
         <groupId>org.bouncycastle</groupId>
         <artifactId>bcprov-jdk15on</artifactId>
-        <version>${bcprov-jdk15on.version}</version>
+        <version>${bouncycastle.version}</version>
+      </dependency>
+      <dependency>
+        <groupId>org.bouncycastle</groupId>

Review Comment:
   Why is this needed to be explicitly added as dependency? Is this not shipped as a part of bcprov-jdk15on? Wondering how was it working with 1.64



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org