You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by SteveKing <st...@gmx.ch> on 2003/09/02 17:39:12 UTC
error not passed to clients
Hi,
yesterday I updated subversion to HEAD and spent this day
adjusting TSVN to work with the new status-API and the
new prompting providers (btw: a big thanks for those!).
Now I'm at testing some functions and found the following:
If I'm asking for a status with "update" set to true (something
like 'svn st -u') on a https:// repository, then the prompting
provider asked me (as it should) if I wanted to accept the
unknown certificate. If I say yes everything is ok, but if
I say no then the function still returns a valid status, just
all remote statuses are set as "deleted". Even if I create
a subversion error and return that in the prompting
callback the function succeeds.
There's no way for me to check if the function was
successful or if it failed (because of the not accepted
certificate) since that error isn't passed through to
the client.
It does this with the command line client too, but
since the client doesn't show the remote status in
detail but just an asterisk it doesn't matter that much.
Is it possible to pass such errors to clients?
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: error not passed to clients
Posted by Ben Collins-Sussman <su...@collab.net>.
"SteveKing" <st...@gmx.ch> writes:
> May I file an issue for this so it doesn't get lost?
Sure.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: error not passed to clients
Posted by SteveKing <st...@gmx.ch>.
----- Original Message -----
From: "Ben Collins-Sussman" <su...@collab.net>
> > Is it possible to pass such errors to clients?
> >
>
> I think this sounds like a reasonable request. If an application runs
>
> svn_client_status ("-u", ...)
>
> ... and a network error happens, that function should definitely throw
> the error back to the application, not silently return status data
> that's missing network information.
>
> I'm not really familiar with all the new streamy status code that
> cmpilato wrote last week. Is it an easy fix? If so, can someone
> post/test a patch?
Seems there's noone working on this, and I'm sorry I can't do
this myself since I'm not familiar with neon or that part of
subversion.
May I file an issue for this so it doesn't get lost?
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: error not passed to clients
Posted by SteveKing <st...@gmx.ch>.
----- Original Message -----
From: "Ben Collins-Sussman" <su...@collab.net>
>
> > Is it possible to pass such errors to clients?
> >
>
> I think this sounds like a reasonable request. If an application runs
>
> svn_client_status ("-u", ...)
>
> ... and a network error happens, that function should definitely throw
> the error back to the application, not silently return status data
> that's missing network information.
>
> I'm not really familiar with all the new streamy status code that
> cmpilato wrote last week. Is it an easy fix? If so, can someone
> post/test a patch?
I tried to trace the functions from the prompt callback back
to the status function. While doing that I found a comment
in the file libsvn_ra_dav/props.c (right at the bottom of the file):
/* ### This is way too general. We should only convert the
* error to `svn_node_none' if we're sure that's what the error
* means; for example, the test used to be this
*
* (err && (err->apr_err == SVN_ERR_RA_DAV_PROPS_NOT_FOUND))
*
* which seemed reasonable...
*
* However, right now svn_ra_dav__get_props() returns a generic
* error when the entity doesn't exist. It's APR_EGENERAL or
* something like that, and ne_get_status(req)->code == 500, not
* 404. I don't know whether this is something that can be
* improved just in that function, or if the server will need to
* be more descriptive about the error. Greg, thoughts?
*/
Maybe this helps someone who's familiar with the code?
I don't know how to fix this myself since I got completely lost
in the neon functions...
Stefan
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: error not passed to clients
Posted by Ben Collins-Sussman <su...@collab.net>.
"SteveKing" <st...@gmx.ch> writes:
> Is it possible to pass such errors to clients?
>
I think this sounds like a reasonable request. If an application runs
svn_client_status ("-u", ...)
... and a network error happens, that function should definitely throw
the error back to the application, not silently return status data
that's missing network information.
I'm not really familiar with all the new streamy status code that
cmpilato wrote last week. Is it an easy fix? If so, can someone
post/test a patch?
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org