You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/10/07 17:12:34 UTC
[GitHub] [pulsar-helm-chart] milos-matijasevic opened a new pull request #73: Updating pods on configmap change
milos-matijasevic opened a new pull request #73:
URL: https://github.com/apache/pulsar-helm-chart/pull/73
Fixes #71
### Motivation
Pods are not restarting when config maps are changed after changing values.yaml file, so they need to be restarted manually in order to pick up new values from config map.
### Modifications
As I mentioned `restartPodsOnConfigMapChange` flag for each component is added in values.yaml file whether to restart pods on configmap change or not, default is `false`.
In statefulset templates for each component is added part which is adding annotation that contains hash of corresponding configmap if `restartPodsOnConfigMapChange` is `true`, which will cause pods to restart if corresponding configmap has been changed (https://helm.sh/docs/howto/charts_tips_and_tricks/#automatically-roll-deployments).
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] milos-matijasevic removed a comment on pull request #73: Updating pods on configmap change
Posted by GitBox <gi...@apache.org>.
milos-matijasevic removed a comment on pull request #73:
URL: https://github.com/apache/pulsar-helm-chart/pull/73#issuecomment-726184646
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] jeantil commented on pull request #73: Updating pods on configmap change
Posted by GitBox <gi...@apache.org>.
jeantil commented on pull request #73:
URL: https://github.com/apache/pulsar-helm-chart/pull/73#issuecomment-722966421
The CI error suggests that there was an issue with the ci platform when your PR was submitted, ulterior PRs seem to have passed the tests. Can you try to rebase on the latest master to trigger a new CI build ? (I'm quite interested in this too :D )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] milos-matijasevic commented on pull request #73: Updating pods on configmap change
Posted by GitBox <gi...@apache.org>.
milos-matijasevic commented on pull request #73:
URL: https://github.com/apache/pulsar-helm-chart/pull/73#issuecomment-726168894
hello, @sijie after #76 is merged i want to rerun CI tests, is there way to do it ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] milos-matijasevic commented on pull request #73: Updating pods on configmap change
Posted by GitBox <gi...@apache.org>.
milos-matijasevic commented on pull request #73:
URL: https://github.com/apache/pulsar-helm-chart/pull/73#issuecomment-726184646
/pulsarbot run-failure-checks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] MMeent commented on pull request #73: Updating pods on configmap change
Posted by GitBox <gi...@apache.org>.
MMeent commented on pull request #73:
URL: https://github.com/apache/pulsar-helm-chart/pull/73#issuecomment-829391464
I've noticed that there are indentation issues for several of the templates, so I've filed #116, and created a PR at #117 to fix those specific issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] sijie commented on pull request #73: Updating pods on configmap change
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #73:
URL: https://github.com/apache/pulsar-helm-chart/pull/73#issuecomment-726487830
@milos-matijasevic You can rebase your pull request to the latest master and push to your branch. It then will trigger the CI to run again.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] milos-matijasevic commented on pull request #73: Updating pods on configmap change
Posted by GitBox <gi...@apache.org>.
milos-matijasevic commented on pull request #73:
URL: https://github.com/apache/pulsar-helm-chart/pull/73#issuecomment-706945284
This already exists in kafkaesque-io pulsar chart, https://github.com/kafkaesque-io/pulsar-helm-chart/blob/master/helm-chart-sources/pulsar/templates/bookkeeper-statefulset.yaml#L53 in pretty much same form, i just added config flag for every deployment/statefulset separately
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] sijie merged pull request #73: Updating pods on configmap change
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #73:
URL: https://github.com/apache/pulsar-helm-chart/pull/73
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org