You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/05/14 19:53:27 UTC

[GitHub] [airflow] kaxil opened a new pull request #15863: Remove unused licenses from LICENSE

kaxil opened a new pull request #15863:
URL: https://github.com/apache/airflow/pull/15863


   Missed it in #15860 + we can remove rich too -- I had advised wrongly that we might have to add license -- but we only need to add license if we include/vendor it in source code
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil commented on a change in pull request #15863: Remove unused licenses from LICENSE

Posted by GitBox <gi...@apache.org>.
kaxil commented on a change in pull request #15863:
URL: https://github.com/apache/airflow/pull/15863#discussion_r632764681



##########
File path: LICENSE
##########
@@ -238,9 +238,6 @@ The text of each license is also included at licenses/LICENSE-[project].txt.
     (MIT License) ElasticMock v1.3.2 (https://github.com/vrcmarcos/elasticmock)
     (MIT License) MomentJS v2.24.0 (http://momentjs.com/)
     (MIT License) moment-strftime v0.5.0 (https://github.com/benjaminoakes/moment-strftime)
-    (MIT License) python-slugify v4.0.0 (https://github.com/un33k/python-slugify)
-    (MIT License) python-nvd3 v0.15.0 (https://github.com/areski/python-nvd3)
-    (MIT License) rich v9.2.0 (https://github.com/willmcgugan/rich)

Review comment:
       License for `rich` was added in https://github.com/apache/airflow/pull/12204/files but isn't needed




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] kaxil merged pull request #15863: Remove unused licenses from LICENSE

Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #15863:
URL: https://github.com/apache/airflow/pull/15863


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] github-actions[bot] commented on pull request #15863: Remove unused licenses from LICENSE

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #15863:
URL: https://github.com/apache/airflow/pull/15863#issuecomment-841509735


   The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest master or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org