[GitHub] [maven-surefire] Tibor17 edited a comment on pull request #462: [SUREFIRE-2006] Don't use Services Transformer in shadefire

[GitBox <gi...@apache.org>]

Tibor17 edited a comment on pull request #462:
URL: https://github.com/apache/maven-surefire/pull/462#issuecomment-1033227529


   It's good that you have looked at it.
   After checking the original content of the JAR, the SPI was there 4 times and the sources too.
   Now it is without duplicates of `*.class` and SPI?
   
   The POJO test should not be modified like this because the users will not use the `ShadeFire` provider. This provider was developed mainly for our internal purposes. The POJO does not need to have any JUnit dependency and no provider because it assumes that the tests are so simple where the public test methods start with name `test`.
   Anyway, if you like to test the `ShadeFire`, it's good but we should also keep the original IT and this can be accomplished by adding a new Maven profile for ShadeFire in the IT's POM which is maybe the most simple solution.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org