Re: [PR] GH-3466: Improve `RunLengthBitPackingHybridDecoder.readNext` to avoid per-call buffer allocation and `DataInputStream` wrapping [parquet-java]

["arouel (via GitHub)" <gi...@apache.org>]

arouel commented on PR #3467:
URL: https://github.com/apache/parquet-java/pull/3467#issuecomment-4720904972

   > I've left one fix that addresses a concern is that `currentBuffer` retains stale values from a previous larger packed run in positions beyond `currentCount`. While those positions are never accessed today (the indexing is bounded by `currentBufferLength`), it's a latent risk. Let's add defensive zeroing, consistent with how packedBytes is zeroed on short reads.
   
   Thank you for the review. I applied the code changes as suggested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@parquet.apache.org
For additional commands, e-mail: issues-help@parquet.apache.org