You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Sergey Urbanovich <se...@gmail.com> on 2018/08/21 19:16:05 UTC
Review Request 68448: Skip the container if there's no container
network.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68448/
-----------------------------------------------------------
Review request for mesos, Jie Yu and Jiang Yan Xu.
Bugs: MESOS-9171
https://issues.apache.org/jira/browse/MESOS-9171
Repository: mesos
Description
-------
If the container wants to join host network it won't have container
networks. In that case `rootDir` could be not configured and
`rootDir.get()` in `usage()` will cause mesos agent crash.
Diffs
-----
src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 6df52a55b13675df593872559b5238e8a10fd666
Diff: https://reviews.apache.org/r/68448/diff/1/
Testing
-------
bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.VETH_VerifyResourceStatistics" --gtest_break_on_failure --gtest_repeat=100
Thanks,
Sergey Urbanovich
Re: Review Request 68448: Skip the container if there's no container
network.
Posted by Jiang Yan Xu <ya...@jxu.me>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68448/#review207693
-----------------------------------------------------------
Ship it!
Ship It!
- Jiang Yan Xu
On Aug. 21, 2018, 12:16 p.m., Sergey Urbanovich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68448/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 12:16 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Bugs: MESOS-9171
> https://issues.apache.org/jira/browse/MESOS-9171
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the container wants to join host network it won't have container
> networks. In that case `rootDir` could be not configured and
> `rootDir.get()` in `usage()` will cause mesos agent crash.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 6df52a55b13675df593872559b5238e8a10fd666
>
>
> Diff: https://reviews.apache.org/r/68448/diff/1/
>
>
> Testing
> -------
>
> bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.VETH_VerifyResourceStatistics" --gtest_break_on_failure --gtest_repeat=100
>
>
> Thanks,
>
> Sergey Urbanovich
>
>
Re: Review Request 68448: Skip the container if there's no container
network.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68448/#review207684
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Aug. 21, 2018, 7:16 p.m., Sergey Urbanovich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68448/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 7:16 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Bugs: MESOS-9171
> https://issues.apache.org/jira/browse/MESOS-9171
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the container wants to join host network it won't have container
> networks. In that case `rootDir` could be not configured and
> `rootDir.get()` in `usage()` will cause mesos agent crash.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 6df52a55b13675df593872559b5238e8a10fd666
>
>
> Diff: https://reviews.apache.org/r/68448/diff/1/
>
>
> Testing
> -------
>
> bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.VETH_VerifyResourceStatistics" --gtest_break_on_failure --gtest_repeat=100
>
>
> Thanks,
>
> Sergey Urbanovich
>
>
Re: Review Request 68448: Skip the container if there's no container
network.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68448/#review207704
-----------------------------------------------------------
PASS: Mesos patch 68448 was successfully built and tested.
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2208/mesos-review-68448
- Mesos Reviewbot Windows
On Aug. 21, 2018, 12:16 p.m., Sergey Urbanovich wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68448/
> -----------------------------------------------------------
>
> (Updated Aug. 21, 2018, 12:16 p.m.)
>
>
> Review request for mesos, Jie Yu and Jiang Yan Xu.
>
>
> Bugs: MESOS-9171
> https://issues.apache.org/jira/browse/MESOS-9171
>
>
> Repository: mesos
>
>
> Description
> -------
>
> If the container wants to join host network it won't have container
> networks. In that case `rootDir` could be not configured and
> `rootDir.get()` in `usage()` will cause mesos agent crash.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 6df52a55b13675df593872559b5238e8a10fd666
>
>
> Diff: https://reviews.apache.org/r/68448/diff/1/
>
>
> Testing
> -------
>
> bin/mesos-tests.sh --verbose --gtest_filter="CniIsolatorTest.VETH_VerifyResourceStatistics" --gtest_break_on_failure --gtest_repeat=100
>
>
> Thanks,
>
> Sergey Urbanovich
>
>