You are viewing a plain text version of this content. The canonical link for it is here.
Posted to doxia-dev@maven.apache.org by Vincent Siveton <vi...@gmail.com> on 2007/07/18 00:24:24 UTC
Re: svn commit: r557051 - in /maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc: XdocParser.java XdocSink.java
Hi Lukas,
2007/7/17, ltheussl@apache.org <lt...@apache.org>:
> Author: ltheussl
> Date: Tue Jul 17 13:45:47 2007
> New Revision: 557051
>
> URL: http://svn.apache.org/viewvc?view=rev&rev=557051
> Log:
> Various fixes to Xdoc parser:
> - don't emit anchor for section titles (should be done by a sink if desired)
I think it was handle by the TOCMacro. Could you have a glance on this?
> - handle <h4>, <h5>, <h6> tags as section3, section4, section5
> - distinguish between un-ordered and ordered list items
> - only use the colspan attribute of table (header) cells if it is non-null
> - add lineBreak, horizontalRule, monospaced, definition list and img parsing
> - don't emit text events if text is just white space
>
Great! Thanks for these!
Cheers,
Vincent
[SNIP]
Re: svn commit: r557051 - in /maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc: XdocParser.java XdocSink.java
Posted by Jason van Zyl <ja...@maven.org>.
On 21 Jul 07, at 9:51 PM 21 Jul 07, Vincent Siveton wrote:
> Hi Lukas,
>
> Could you correct it or revert it?
>
Once that's done I can try out the new plexus single jar setup. It
appears to be working for the maven bootstrap and if I can properly
try out doxia and it works I can roll it all in.
> Thanks,
>
> Vincent
>
> 2007/7/19, Dennis Lundberg <de...@apache.org>:
>> I've gotten 3 messages informing of failures in
>> org.apache.maven.doxia.siterenderer.DefaultSiteRendererTest
>>
>> but when I look in the mail-archive I see 5 messages.
>>
>> Subject:
>> [continuum] BUILD FAILURE: Doxia Site Renderer Component
>>
>>
>> I have missed several (Maven-mailing-list) messages lately, but I
>> thought it was something wrong with my mail-provider, since the
>> messages
>> are available in the archives.
>>
>> Lukas Theussl wrote:
>> > I know, I am subscribed, did I miss it?
>> >
>> > -Lukas
>> >
>> >
>> > Dennis Lundberg wrote:
>> >> Lukas Theussl wrote:
>> >>
>> >>> It seems like I did break something after all: the site-
>> renderer test
>> >>> now fails (btw, I only noticed it by accident on the continuum
>> page,
>> >>> there was no notification sent?).
>> >>
>> >>
>> >> The notifications are sent to notifications@maven.apache.org
>> >>
>> >>
>> >> <snip/>
>> >>
>>
>>
>> --
>> Dennis Lundberg
>>
Thanks,
Jason
----------------------------------------------------------
Jason van Zyl
Founder and PMC Chair, Apache Maven
jason at sonatype dot com
----------------------------------------------------------
Re: svn commit: r557051 - in /maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc:
XdocParser.java XdocSink.java
Posted by Lukas Theussl <lt...@apache.org>.
Yes, yes, yes.. :)
Sorry, I didn't mean to to leave that dangling but I was somewhat
unavailable this weekend, - I'll try to fix it tonight.
I guess I will revert at least part of my commits so we can get alpha-9
out with the previous behavior, but IMO we'll have to break a few things
for beta-1.
-Lukas
Vincent Siveton wrote:
> Hi Lukas,
>
> Could you correct it or revert it?
>
> Thanks,
>
> Vincent
>
> 2007/7/19, Dennis Lundberg <de...@apache.org>:
>
>> I've gotten 3 messages informing of failures in
>> org.apache.maven.doxia.siterenderer.DefaultSiteRendererTest
>>
>> but when I look in the mail-archive I see 5 messages.
>>
>> Subject:
>> [continuum] BUILD FAILURE: Doxia Site Renderer Component
>>
>>
>> I have missed several (Maven-mailing-list) messages lately, but I
>> thought it was something wrong with my mail-provider, since the messages
>> are available in the archives.
>>
>> Lukas Theussl wrote:
>> > I know, I am subscribed, did I miss it?
>> >
>> > -Lukas
>> >
>> >
>> > Dennis Lundberg wrote:
>> >> Lukas Theussl wrote:
>> >>
>> >>> It seems like I did break something after all: the site-renderer test
>> >>> now fails (btw, I only noticed it by accident on the continuum page,
>> >>> there was no notification sent?).
>> >>
>> >>
>> >> The notifications are sent to notifications@maven.apache.org
>> >>
>> >>
>> >> <snip/>
>> >>
>>
>>
>> --
>> Dennis Lundberg
>>
Re: svn commit: r557051 - in /maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc: XdocParser.java XdocSink.java
Posted by Vincent Siveton <vi...@gmail.com>.
Hi Lukas,
Could you correct it or revert it?
Thanks,
Vincent
2007/7/19, Dennis Lundberg <de...@apache.org>:
> I've gotten 3 messages informing of failures in
> org.apache.maven.doxia.siterenderer.DefaultSiteRendererTest
>
> but when I look in the mail-archive I see 5 messages.
>
> Subject:
> [continuum] BUILD FAILURE: Doxia Site Renderer Component
>
>
> I have missed several (Maven-mailing-list) messages lately, but I
> thought it was something wrong with my mail-provider, since the messages
> are available in the archives.
>
> Lukas Theussl wrote:
> > I know, I am subscribed, did I miss it?
> >
> > -Lukas
> >
> >
> > Dennis Lundberg wrote:
> >> Lukas Theussl wrote:
> >>
> >>> It seems like I did break something after all: the site-renderer test
> >>> now fails (btw, I only noticed it by accident on the continuum page,
> >>> there was no notification sent?).
> >>
> >>
> >> The notifications are sent to notifications@maven.apache.org
> >>
> >>
> >> <snip/>
> >>
>
>
> --
> Dennis Lundberg
>
Re: svn commit: r557051 - in /maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc:
XdocParser.java XdocSink.java
Posted by Dennis Lundberg <de...@apache.org>.
I've gotten 3 messages informing of failures in
org.apache.maven.doxia.siterenderer.DefaultSiteRendererTest
but when I look in the mail-archive I see 5 messages.
Subject:
[continuum] BUILD FAILURE: Doxia Site Renderer Component
I have missed several (Maven-mailing-list) messages lately, but I
thought it was something wrong with my mail-provider, since the messages
are available in the archives.
Lukas Theussl wrote:
> I know, I am subscribed, did I miss it?
>
> -Lukas
>
>
> Dennis Lundberg wrote:
>> Lukas Theussl wrote:
>>
>>> It seems like I did break something after all: the site-renderer test
>>> now fails (btw, I only noticed it by accident on the continuum page,
>>> there was no notification sent?).
>>
>>
>> The notifications are sent to notifications@maven.apache.org
>>
>>
>> <snip/>
>>
--
Dennis Lundberg
Re: svn commit: r557051 - in /maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc:
XdocParser.java XdocSink.java
Posted by Lukas Theussl <lt...@apache.org>.
I know, I am subscribed, did I miss it?
-Lukas
Dennis Lundberg wrote:
> Lukas Theussl wrote:
>
>> It seems like I did break something after all: the site-renderer test
>> now fails (btw, I only noticed it by accident on the continuum page,
>> there was no notification sent?).
>
>
> The notifications are sent to notifications@maven.apache.org
>
>
> <snip/>
>
Re: svn commit: r557051 - in /maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc:
XdocParser.java XdocSink.java
Posted by Dennis Lundberg <de...@apache.org>.
Lukas Theussl wrote:
> It seems like I did break something after all: the site-renderer test
> now fails (btw, I only noticed it by accident on the continuum page,
> there was no notification sent?).
The notifications are sent to notifications@maven.apache.org
<snip/>
--
Dennis Lundberg
Re: svn commit: r557051 - in /maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc:
XdocParser.java XdocSink.java
Posted by Lukas Theussl <lt...@apache.org>.
It seems like I did break something after all: the site-renderer test
now fails (btw, I only noticed it by accident on the continuum page,
there was no notification sent?).
It doesn't seem logical though to me, maybe this should be fixed in the
site renderer. Anyway, if I don't come up with a better solution, I'll
revert that part.
-Lukas
Lukas Theussl wrote:
> The TOCMacro only generates the links, not the anchors, there is a test
> case for it (and I didn't break it! :) ). Logically, I would say it's a
> low-level sink (eg the SiteRendererSink) that should put the anchors in
> place, not the parser (also I don't see eg the AptParser emit any
> anchors for section titles, does it?). Section anchors only make sense
> in an end-user presentation format (xhtml, pdf), you don't want explicit
> anchors to clutter your xdoc or apt sources. But then, I'm not sure I
> didn't break anything, I never used the macro.
>
> -Lukas
>
>
> Vincent Siveton wrote:
>
>> Hi Lukas,
>>
>> 2007/7/17, ltheussl@apache.org <lt...@apache.org>:
>>
>>> Author: ltheussl
>>> Date: Tue Jul 17 13:45:47 2007
>>> New Revision: 557051
>>>
>>> URL: http://svn.apache.org/viewvc?view=rev&rev=557051
>>> Log:
>>> Various fixes to Xdoc parser:
>>> - don't emit anchor for section titles (should be done by a sink if
>>> desired)
>>
>>
>>
>> I think it was handle by the TOCMacro. Could you have a glance on this?
>>
>>> - handle <h4>, <h5>, <h6> tags as section3, section4, section5
>>> - distinguish between un-ordered and ordered list items
>>> - only use the colspan attribute of table (header) cells if it is
>>> non-null
>>> - add lineBreak, horizontalRule, monospaced, definition list and img
>>> parsing
>>> - don't emit text events if text is just white space
>>>
>>
>> Great! Thanks for these!
>>
>> Cheers,
>>
>> Vincent
>>
>> [SNIP]
Re: svn commit: r557051 - in /maven/doxia/doxia/trunk/doxia-modules/doxia-module-xdoc/src/main/java/org/apache/maven/doxia/module/xdoc:
XdocParser.java XdocSink.java
Posted by Lukas Theussl <lt...@apache.org>.
The TOCMacro only generates the links, not the anchors, there is a test
case for it (and I didn't break it! :) ). Logically, I would say it's a
low-level sink (eg the SiteRendererSink) that should put the anchors in
place, not the parser (also I don't see eg the AptParser emit any
anchors for section titles, does it?). Section anchors only make sense
in an end-user presentation format (xhtml, pdf), you don't want explicit
anchors to clutter your xdoc or apt sources. But then, I'm not sure I
didn't break anything, I never used the macro.
-Lukas
Vincent Siveton wrote:
> Hi Lukas,
>
> 2007/7/17, ltheussl@apache.org <lt...@apache.org>:
>
>> Author: ltheussl
>> Date: Tue Jul 17 13:45:47 2007
>> New Revision: 557051
>>
>> URL: http://svn.apache.org/viewvc?view=rev&rev=557051
>> Log:
>> Various fixes to Xdoc parser:
>> - don't emit anchor for section titles (should be done by a sink if
>> desired)
>
>
> I think it was handle by the TOCMacro. Could you have a glance on this?
>
>> - handle <h4>, <h5>, <h6> tags as section3, section4, section5
>> - distinguish between un-ordered and ordered list items
>> - only use the colspan attribute of table (header) cells if it is
>> non-null
>> - add lineBreak, horizontalRule, monospaced, definition list and img
>> parsing
>> - don't emit text events if text is just white space
>>
>
> Great! Thanks for these!
>
> Cheers,
>
> Vincent
>
> [SNIP]