[GitHub] spark pull request #16320: [SPARK-18877][SQL] `CSVInferSchema.inferField` on...

[cloud-fan <gi...@git.apache.org>]

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16320#discussion_r94357821
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVInferSchema.scala ---
    @@ -85,7 +85,9 @@ private[csv] object CSVInferSchema {
             case NullType => tryParseInteger(field, options)
             case IntegerType => tryParseInteger(field, options)
             case LongType => tryParseLong(field, options)
    -        case _: DecimalType => tryParseDecimal(field, options)
    +        case _: DecimalType =>
    +          // DecimalTypes have different precisions and scales, so we try to find the common type.
    +          findTightestCommonType(typeSoFar, tryParseDecimal(field, options)).getOrElse(NullType)
    --- End diff --
    
    Looks like the fallback policy here is to use `StringType`, shoud we follow?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org