You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/08/09 06:24:54 UTC
[GitHub] [shardingsphere] azexcy opened a new pull request, #20013: Refactor InventoryTaskSplitter for common usage
azexcy opened a new pull request, #20013:
URL: https://github.com/apache/shardingsphere/pull/20013
Fixes #19976.
Changes proposed in this pull request:
- Refactor InventoryTaskSplitter for common usage
- Move AbstractPipelineJob
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on a diff in pull request #20013: Refactor InventoryTaskSplitter for common usage
Posted by GitBox <gi...@apache.org>.
sandynz commented on code in PR #20013:
URL: https://github.com/apache/shardingsphere/pull/20013#discussion_r941102604
##########
shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-api/src/main/java/org/apache/shardingsphere/data/pipeline/api/context/PipelineJobContext.java:
##########
@@ -66,4 +69,25 @@ public interface PipelineJobContext {
* @return job process context
*/
PipelineProcessContext getJobProcessContext();
+
+ /**
+ * Get task configuration.
+ *
+ * @return task configuration
+ */
+ TaskConfiguration getTaskConfig();
+
+ /**
+ * Get init progress.
+ *
+ * @return init progress
+ */
+ JobProgress getInitProgress();
+
+ /**
+ * Get source data source.
+ *
+ * @return source data source
+ */
+ PipelineDataSourceWrapper getSourceDataSource();
Review Comment:
It's better not put them in `PipelineJobContext`.
We could transfer these fields to InventoryTaskSplitter, or add them in sub-interface of PipelineJobContext.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #20013: Refactor InventoryTaskSplitter for common usage
Posted by GitBox <gi...@apache.org>.
sandynz commented on PR #20013:
URL: https://github.com/apache/shardingsphere/pull/20013#issuecomment-1209387118
Used to reproduce #20035, it won't be merged for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz merged pull request #20013: Refactor InventoryTaskSplitter for common usage
Posted by GitBox <gi...@apache.org>.
sandynz merged PR #20013:
URL: https://github.com/apache/shardingsphere/pull/20013
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org