You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/10/19 05:53:11 UTC

[GitHub] [calcite] jinxing64 commented on a change in pull request #1422: [CALCITE-3300] Add a star identifier as operand to "SqlCountAggFunction" if no operands given while in the method "createCall"

jinxing64 commented on a change in pull request #1422: [CALCITE-3300] Add a star identifier as operand to "SqlCountAggFunction" if no operands given while in the method "createCall"
URL: https://github.com/apache/calcite/pull/1422#discussion_r336723200
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/rel/rel2sql/RelToSqlConverterTest.java
 ##########
 @@ -4038,17 +4058,25 @@ Sql throws_(String errorMessage) {
       }
     }
 
-    String exec() {
+    SqlNode exec0() {
       final Planner planner =
-          getPlanner(null, SqlParser.Config.DEFAULT, schema, config);
+              getPlanner(null, SqlParser.Config.DEFAULT, schema, config);
 
 Review comment:
   No need for this change

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services