[GitHub] earlymeme commented on a change in pull request #9517: add legend.disabled

[GitBox <gi...@apache.org>]

earlymeme commented on a change in pull request #9517: add legend.disabled
URL: https://github.com/apache/incubator-echarts/pull/9517#discussion_r238501864
 
 

 ##########
 File path: src/component/legend/LegendModel.js
 ##########
 @@ -169,10 +170,14 @@ var LegendModel = echarts.extendComponentModel({
      */
     toggleSelected: function (name) {
         var selected = this.option.selected;
+        var disabled = this.option.disabled;
         // Default is true
         if (!selected.hasOwnProperty(name)) {
             selected[name] = true;
         }
+        if (!disabled.hasOwnProperty(name) && disabled[name] === true){
 
 Review comment:
   ```suggestion
           if (!disabled.hasOwnProperty(name) && disabled[name] === true) {
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@echarts.apache.org
For additional commands, e-mail: dev-help@echarts.apache.org