You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ofbiz.apache.org by "PierreSmits (via GitHub)" <gi...@apache.org> on 2024/04/14 11:23:04 UTC

[PR] Improved: Reduce code complexity re marketing menus (OFBIZ-13025) [ofbiz-framework]

PierreSmits opened a new pull request, #757:
URL: https://github.com/apache/ofbiz-framework/pull/757

   Currently, we have in the marketing component/application - besides the main menus (in MarketingMenus.xml, menus for specific screens/functions in:
   * ContactListMenus.xml: 2 menus, with resp. 5 and 2 menu-items; used in ContactListScreens.xml
   * DataSourcesMenus.xml: 1 menu, with 2 menu-items; used in DataSourceScreens.xml
   * MarketingCampaignMenus.xml: 1 menu, with 2 menu-items; used in MarketingCampaignScreens.xml *SegmentMenus.xml: 1 menu, with 4 menu-items; used in SegmentScreens.xml*TrackingCodeMenus.xml: 1 menu, with 4 menu-items, used in TrackingCodeScreens.xml
   
   We should move the menus in those menu xml file to MarketingMenus.xml (and adjust the location references in the appropriate screens) to reduce code complexity and enhance the developer experience.
   
   modified:
   * MarketingMenus.xml: added menus, ContactListTabBar, ContactListComBar, DataSourceTabBar, MarketingCampaignTabBar, SegmentGroupTabBar, TrackingCodeTabBar
   * CommonScreens.xml, ContactListScreens,xml, DataSoourceScreen.xml, MarketingCampaignScreens.xml, SegmentScreens.xml, TrackingCodeScreens.xml: changed menu location from hardcoded to parameterized
   
   deleted: ContactListMenus.xml, DataSourceMenus.xml, MarketingCampaignMenus.xml, SegmentMenus.xml, TrackingCodeMenus.xml


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: Reduce code complexity re marketing menus (OFBIZ-13025) [ofbiz-framework]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #757:
URL: https://github.com/apache/ofbiz-framework/pull/757#issuecomment-2054016083

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=757) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=757&resolved=false&inNewCodePeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=757&metric=new_accepted_issues&view=list)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=757&resolved=false&inNewCodePeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Coverage  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=757&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=757)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: Reduce code complexity re marketing menus (OFBIZ-13025) [ofbiz-framework]

Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #757:
URL: https://github.com/apache/ofbiz-framework/pull/757#issuecomment-2054016439

   ## [![Quality Gate Passed](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/checks/QualityGateBadge/qg-passed-20px.png 'Quality Gate Passed')](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=757) **Quality Gate passed**  
   Issues  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 New issues](https://sonarcloud.io/project/issues?id=apache_ofbiz-framework&pullRequest=757&resolved=false&inNewCodePeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/accepted-16px.png '') [0 Accepted issues](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=757&metric=new_accepted_issues&view=list)
   
   Measures  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_ofbiz-framework&pullRequest=757&resolved=false&inNewCodePeriod=true)  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/no-data-16px.png '') No data about Coverage  
   ![](https://sonarsource.github.io/sonarcloud-github-static-resources/v2/common/passed-16px.png '') [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_ofbiz-framework&pullRequest=757&metric=new_duplicated_lines_density&view=list)  
     
   [See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_ofbiz-framework&pullRequest=757)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Improved: Reduce code complexity re marketing menus (OFBIZ-13025) [ofbiz-framework]

Posted by "JacquesLeRoux (via GitHub)" <gi...@apache.org>.
JacquesLeRoux merged PR #757:
URL: https://github.com/apache/ofbiz-framework/pull/757


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ofbiz.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org