You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@jakarta.apache.org by bu...@apache.org on 2011/01/27 07:48:54 UTC
DO NOT REPLY [Bug 50666] New: JMS support for durable subscriptions
https://issues.apache.org/bugzilla/show_bug.cgi?id=50666
Summary: JMS support for durable subscriptions
Product: JMeter
Version: unspecified
Platform: All
OS/Version: All
Status: NEW
Severity: enhancement
Priority: P3
Component: Main
AssignedTo: notifications@jakarta.apache.org
ReportedBy: chris.issues@gmx.net
Created an attachment (id=26559)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26559)
Patch to support durable subscriptions to JMS Subscriber Sampler
Here is a patch that adds support for durable subscriptions to the JMS
Subscriber Sampler.
It was created against trunk as of yesterday morning (revision 1063734).
This is my very first contribution of this kind, and although I have spent
quite some time going through various documentation, I may well have missed
some guideline.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50666] JMS support for durable subscriptions
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50666
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEEDINFO |RESOLVED
Resolution| |FIXED
--- Comment #8 from Sebb <se...@apache.org> 2011-03-18 07:36:46 EDT ---
Thanks, committed:
URL: http://svn.apache.org/viewvc?rev=1082871&view=rev
Log:
Bug 50666 - JMSSubscriber: support for durable subscriptions
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50666] JMS support for durable subscriptions
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50666
--- Comment #3 from Christoph Jahn <ch...@gmx.net> 2011-01-29 02:11:51 EST ---
Created an attachment (id=26574)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26574)
Screenshot of JMS Subscriber sampler
Shows the "Durable Subscription ID" field
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50666] JMS support for durable subscriptions
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50666
Christoph Jahn <ch...@gmx.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26559|0 |1
is obsolete| |
--- Comment #2 from Christoph Jahn <ch...@gmx.net> 2011-01-29 02:10:05 EST ---
Created an attachment (id=26573)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26573)
Patch to support durable subscriptions to JMS Subscriber Sampler
Revised patch:
- updated component_reference.xml
- uses setProperty() with default
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50666] JMS support for durable subscriptions
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50666
--- Comment #7 from Christoph Jahn <ch...@gmx.net> 2011-03-18 01:39:28 EDT ---
Created an attachment (id=26784)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26784)
Addendum to patch v3 with component_reference.xml
And here the missing component_reference.xml. Thanks for catching that!
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50666] JMS support for durable subscriptions
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50666
--- Comment #1 from Sebb <se...@apache.org> 2011-01-27 07:23:19 EST ---
Thanks!
Patch looks generally OK from a visual inspection.
It would be helpful to also have a patch for the documentation, i.e.
component_reference.xml, which explains what the new field does.
BTW, the getProperty() and setProperty() methods have versions which provide
defaults. The get default can be used to ensure the value is not null.
The set default is useful to ensure that the property is not added to JMX files
if it is empty. Obviously the same defaults must be used!
We try to use this for new properties, otherwise the JMX files keep growing.
No need to update the patch - that can be fixed later.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50666] JMS support for durable subscriptions
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50666
Christoph Jahn <ch...@gmx.net> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #26573|0 |1
is obsolete| |
--- Comment #5 from Christoph Jahn <ch...@gmx.net> 2011-03-15 03:16:01 EDT ---
Created an attachment (id=26772)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26772)
Patch to support durable subscriptions to JMS Subscriber Sampler (v3)
Sorry for the mess and the delay. This patch should hopefully be ok now
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50666] JMS support for durable subscriptions
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50666
--- Comment #6 from Sebb <se...@apache.org> 2011-03-17 22:34:55 EDT ---
Thanks, the patch fixes the JMX file defaults.
Still no sign of a patch for component_reference.xml however.
If you have done the work, please attach a separate patch containing just that.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org
DO NOT REPLY [Bug 50666] JMS support for durable subscriptions
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=50666
Sebb <se...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |NEEDINFO
--- Comment #4 from Sebb <se...@apache.org> 2011-02-02 18:22:46 EST ---
(In reply to comment #2)
> Created an attachment (id=26573)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=26573) [details]
> Patch to support durable subscriptions to JMS Subscriber Sampler
>
> Revised patch:
> - updated component_reference.xml
> - uses setProperty() with default
The patch file is identical to the previous one - wrong file attached?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@jakarta.apache.org
For additional commands, e-mail: notifications-help@jakarta.apache.org