[GitHub] [daffodil] mbeckerle commented on a change in pull request #768: Daffodil 2663 pluggable charsets

[GitBox <gi...@apache.org>]

mbeckerle commented on a change in pull request #768:
URL: https://github.com/apache/daffodil/pull/768#discussion_r837877288



##########
File path: daffodil-io/src/main/scala/org/apache/daffodil/processors/charset/AISPayloadArmoring.scala
##########
@@ -44,3 +44,19 @@ object BitsCharsetAISPayloadArmoring extends {
   override val replacementCharCode = 0x30
   override val requiredBitOrder = BitOrder.MostSignificantBitFirst
 } with BitsCharsetNonByteSize
+
+final class BitsCharsetAISPayloadArmoringCompiler
+  extends CharsetCompiler("X-DAFFODIL-AIS-PAYLOAD-ARMORING") {
+
+  override def compileCharset() = {
+    new BitsCharsetAISPayloadArmoringTransformerFactory(name)

Review comment:
       Keep in mind if BitsCharsetAISPayloadArmoringFactory can ever fail and issue a diagnostic, the schema author/user knows this as "X-DAFFODIL-AIS-PAYLOAD-ARMORING", and that's the meaningful name to them for use in a diagnostic. That's the only reason I can think of for passing the name. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org