You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "kiranchavala (via GitHub)" <gi...@apache.org> on 2023/02/13 09:43:04 UTC
[GitHub] [cloudstack] kiranchavala opened a new pull request, #7200: Added upper case JPEG extension for icon upload
kiranchavala opened a new pull request, #7200:
URL: https://github.com/apache/cloudstack/pull/7200
### Description
This PR updates the file UploadResourceIcon.vue in directory ui/src/components/view
Currently if a file contains Captial JPEG extension, the icon fails to upload
Changed line number 198 to include capital JPEG extension
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [X] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [X] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7200: Added upper case JPEG extension for icon upload
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#issuecomment-1427719132
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7200)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7200&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7200&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7200&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7200&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7200&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7200: Added upper case JPEG extension for icon upload
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#issuecomment-1437147972
UI build: :heavy_check_mark:
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7200 (QA-JID-52)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on a diff in pull request #7200: Added upper case JPEG extension for icon upload
Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on code in PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#discussion_r1104343656
##########
ui/src/components/view/UploadResourceIcon.vue:
##########
@@ -195,7 +195,7 @@ export default {
this.options.img = ''
},
beforeUpload (file) {
- if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|PNG)$/.test(file.name)) {
+ if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG)$/.test(file.name)) {
Review Comment:
@DaanHoogland
```suggestion
if (!/\.(bmp|jpeg|jpg|png|svg)$/i.test(file.name)) {
```
Ordered the file extensions and used a case insensitive regex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kiranchavala commented on pull request #7200: Added upper case JPEG extension for icon upload
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#issuecomment-1490238192
I manually tested it and it works
@harikrishna-patnala @shwstppr can you review and approve
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kiranchavala commented on a diff in pull request #7200: Added upper case JPEG extension for icon upload
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on code in PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#discussion_r1104315951
##########
ui/src/components/view/UploadResourceIcon.vue:
##########
@@ -195,7 +195,7 @@ export default {
this.options.img = ''
},
beforeUpload (file) {
- if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|PNG)$/.test(file.name)) {
+ if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG)$/.test(file.name)) {
Review Comment:
@DaanHoogland The changes are good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #7200: Added upper case JPEG extension for icon upload
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#issuecomment-1437139893
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kiranchavala commented on a diff in pull request #7200: Added upper case JPEG extension for icon upload
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on code in PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#discussion_r1105644672
##########
ui/src/components/view/UploadResourceIcon.vue:
##########
@@ -195,7 +195,7 @@ export default {
this.options.img = ''
},
beforeUpload (file) {
- if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|PNG)$/.test(file.name)) {
+ if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG)$/.test(file.name)) {
Review Comment:
Tested the change internally and it working fine with case-insensitive regex
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7200: Added upper case JPEG extension for icon upload
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#discussion_r1104358552
##########
ui/src/components/view/UploadResourceIcon.vue:
##########
@@ -195,7 +195,7 @@ export default {
this.options.img = ''
},
beforeUpload (file) {
- if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|PNG)$/.test(file.name)) {
+ if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG)$/.test(file.name)) {
Review Comment:
@kiranchavala can you agree/apply this suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #7200: Added upper case JPEG extension for icon upload
Posted by "shwstppr (via GitHub)" <gi...@apache.org>.
shwstppr commented on PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#issuecomment-1490309227
Also, can we have it in 4.18 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kiranchavala commented on a diff in pull request #7200: Added upper case JPEG extension for icon upload
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on code in PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#discussion_r1104297999
##########
ui/src/components/view/UploadResourceIcon.vue:
##########
@@ -195,7 +195,7 @@ export default {
this.options.img = ''
},
beforeUpload (file) {
- if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|PNG)$/.test(file.name)) {
+ if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG)$/.test(file.name)) {
Review Comment:
@jbampton yes adding BMP will also be good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7200: Added upper case JPEG extension for icon upload
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#discussion_r1104335892
##########
ui/src/components/view/UploadResourceIcon.vue:
##########
@@ -195,7 +195,7 @@ export default {
this.options.img = ''
},
beforeUpload (file) {
- if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|PNG)$/.test(file.name)) {
+ if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG)$/.test(file.name)) {
Review Comment:
@jbampton
```suggestion
if (!/\.(SVG|JPG|JPEG|PNG|BMP)$/.test(file.name.tuUpperCase())) {
```
?
##########
ui/src/components/view/UploadResourceIcon.vue:
##########
@@ -195,7 +195,7 @@ export default {
this.options.img = ''
},
beforeUpload (file) {
- if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|PNG)$/.test(file.name)) {
+ if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG)$/.test(file.name)) {
Review Comment:
@jbampton
```suggestion
if (!/\.(SVG|JPG|JPEG|PNG|BMP)$/.test(file.name.toUpperCase())) {
```
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7200: Added upper case JPEG extension for icon upload
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#discussion_r1104299932
##########
ui/src/components/view/UploadResourceIcon.vue:
##########
@@ -195,7 +195,7 @@ export default {
this.options.img = ''
},
beforeUpload (file) {
- if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|PNG)$/.test(file.name)) {
+ if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG)$/.test(file.name)) {
Review Comment:
well,
```suggestion
if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG|BMP)$/.test(file.name)) {
```
then...?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sonarcloud[bot] commented on pull request #7200: Added upper case JPEG extension for icon upload
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#issuecomment-1437137368
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache_cloudstack&pullRequest=7200)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7200&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7200&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_cloudstack&pullRequest=7200&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=CODE_SMELL) [0 Code Smells](https://sonarcloud.io/project/issues?id=apache_cloudstack&pullRequest=7200&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7200&metric=coverage&view=list) No Coverage information
[](https://sonarcloud.io/component_measures?id=apache_cloudstack&pullRequest=7200&metric=duplicated_lines_density&view=list) No Duplication information
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kiranchavala commented on a diff in pull request #7200: Added upper case JPEG extension for icon upload
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on code in PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#discussion_r1111962724
##########
ui/src/components/view/UploadResourceIcon.vue:
##########
@@ -195,7 +195,7 @@ export default {
this.options.img = ''
},
beforeUpload (file) {
- if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|PNG)$/.test(file.name)) {
+ if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG)$/.test(file.name)) {
Review Comment:
@DaanHoogland applied the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7200: Added upper case JPEG extension for icon upload
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#issuecomment-1437139195
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #7200: Added upper case JPEG extension for icon upload
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#issuecomment-1437199751
@jbampton can you approve?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #7200: Added upper case JPEG extension for icon upload
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland merged PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on a diff in pull request #7200: Added upper case JPEG extension for icon upload
Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on code in PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#discussion_r1104317804
##########
ui/src/components/view/UploadResourceIcon.vue:
##########
@@ -195,7 +195,7 @@ export default {
this.options.img = ''
},
beforeUpload (file) {
- if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|PNG)$/.test(file.name)) {
+ if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG)$/.test(file.name)) {
Review Comment:
Better to have a case insensitive regex to match all variations of the file extensions.
Even a `.JPeg` is valid it seems
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] kiranchavala commented on a diff in pull request #7200: Added upper case JPEG extension for icon upload
Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on code in PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#discussion_r1104375070
##########
ui/src/components/view/UploadResourceIcon.vue:
##########
@@ -195,7 +195,7 @@ export default {
this.options.img = ''
},
beforeUpload (file) {
- if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|PNG)$/.test(file.name)) {
+ if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG)$/.test(file.name)) {
Review Comment:
@DaanHoogland yes making it case insensitive is good thought
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] jbampton commented on a diff in pull request #7200: Added upper case JPEG extension for icon upload
Posted by "jbampton (via GitHub)" <gi...@apache.org>.
jbampton commented on code in PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#discussion_r1104275654
##########
ui/src/components/view/UploadResourceIcon.vue:
##########
@@ -195,7 +195,7 @@ export default {
this.options.img = ''
},
beforeUpload (file) {
- if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|PNG)$/.test(file.name)) {
+ if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG)$/.test(file.name)) {
Review Comment:
Should we also check for `BMP` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #7200: Added upper case JPEG extension for icon upload
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#issuecomment-1427716517
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/7200?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7200](https://codecov.io/gh/apache/cloudstack/pull/7200?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (6ee9f43) into [main](https://codecov.io/gh/apache/cloudstack/commit/dcf01f7bef445a03cc3f8c987e63103055f6ebbc?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (dcf01f7) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #7200 +/- ##
============================================
- Coverage 12.67% 12.67% -0.01%
+ Complexity 8641 8639 -2
============================================
Files 2716 2716
Lines 256112 256112
Branches 39926 39926
============================================
- Hits 32465 32456 -9
- Misses 219517 219528 +11
+ Partials 4130 4128 -2
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/7200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...dstack/network/contrail/model/ModelObjectBase.java](https://codecov.io/gh/apache/cloudstack/pull/7200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdEJhc2UuamF2YQ==) | `28.84% <0.00%> (-15.39%)` | :arrow_down: |
| [...cloudstack/network/contrail/model/ModelObject.java](https://codecov.io/gh/apache/cloudstack/pull/7200?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9uZXR3b3JrLWVsZW1lbnRzL2p1bmlwZXItY29udHJhaWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2Nsb3Vkc3RhY2svbmV0d29yay9jb250cmFpbC9tb2RlbC9Nb2RlbE9iamVjdC5qYXZh) | `29.16% <0.00%> (-4.17%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #7200: Added upper case JPEG extension for icon upload
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #7200:
URL: https://github.com/apache/cloudstack/pull/7200#discussion_r1106781509
##########
ui/src/components/view/UploadResourceIcon.vue:
##########
@@ -195,7 +195,7 @@ export default {
this.options.img = ''
},
beforeUpload (file) {
- if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|PNG)$/.test(file.name)) {
+ if (!/\.(svg|jpg|jpeg|png|bmp|SVG|JPG|JPEG|PNG)$/.test(file.name)) {
Review Comment:
than pleae apply the change @kiranchavala
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org