You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Matt Ryan (JIRA)" <ji...@apache.org> on 2016/12/08 19:31:58 UTC

[jira] [Updated] (OAK-5253) Optimize AbstractBlob#equal to not do content equals when possible

     [ https://issues.apache.org/jira/browse/OAK-5253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Matt Ryan updated OAK-5253:
---------------------------
    Attachment: OAK-5253.1.patch

[~amjain] Please take a look at the attached patch (OAK-5253.1.patch) for 1.5.16 which I think addresses this issue.

I'll try to apply to 1.4 and send a separate patch if one is required.

> Optimize AbstractBlob#equal to not do content equals when possible
> ------------------------------------------------------------------
>
>                 Key: OAK-5253
>                 URL: https://issues.apache.org/jira/browse/OAK-5253
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: blob
>            Reporter: Amit Jain
>            Assignee: Amit Jain
>             Fix For: 1.6, 1.5.16
>
>         Attachments: OAK-5253.1.patch
>
>
> AbstractBlob#equals tries to match content when length is equal and content identities is not null and different. Matching content triggers an expensive download of binaries for S3DataStore.
> Since, right now the content identity is the content hash the check can be short -circuited when the content identities is not null and not equal to return false.
> This can be revisited if we change the identity to something different.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)