You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/12 20:00:39 UTC
[GitHub] [superset] hughhhh opened a new pull request #12471: fix: styling for change dataset confirmation
hughhhh opened a new pull request #12471:
URL: https://github.com/apache/superset/pull/12471
### SUMMARY
<!--- Describe the change below, including rationale and design decisions -->
Set the confirm modal to width 432px
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] hughhhh merged pull request #12471: fix: styling for change dataset confirmation
Posted by GitBox <gi...@apache.org>.
hughhhh merged pull request #12471:
URL: https://github.com/apache/superset/pull/12471
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12471: fix: styling for change dataset confirmation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12471:
URL: https://github.com/apache/superset/pull/12471#issuecomment-759077947
# [Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=h1) Report
> Merging [#12471](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=desc) (d63ceb5) into [master](https://codecov.io/gh/apache/superset/commit/75f927b9ebe4174d9af37ac4d4ce1a043cee77f1?el=desc) (75f927b) will **increase** coverage by `0.28%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12471 +/- ##
==========================================
+ Coverage 62.76% 63.05% +0.28%
==========================================
Files 1015 1015
Lines 49526 50075 +549
Branches 5080 5081 +1
==========================================
+ Hits 31084 31573 +489
- Misses 18233 18293 +60
Partials 209 209
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.75% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `64.52% <ø> (+0.44%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `85.00% <100.00%> (+0.18%)` | :arrow_up: |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `94.54% <0.00%> (-1.20%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.86% <0.00%> (-0.60%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `91.57% <0.00%> (-0.41%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.40% <0.00%> (+1.12%)` | :arrow_up: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `88.18% <0.00%> (+1.60%)` | :arrow_up: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `88.23% <0.00%> (+5.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=footer). Last update [75f927b...d63ceb5](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12471: fix: styling for change dataset confirmation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12471:
URL: https://github.com/apache/superset/pull/12471#issuecomment-759077947
# [Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=h1) Report
> Merging [#12471](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=desc) (d63ceb5) into [master](https://codecov.io/gh/apache/superset/commit/75f927b9ebe4174d9af37ac4d4ce1a043cee77f1?el=desc) (75f927b) will **increase** coverage by `4.10%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12471 +/- ##
==========================================
+ Coverage 62.76% 66.86% +4.10%
==========================================
Files 1015 1015
Lines 49526 50237 +711
Branches 5080 5130 +50
==========================================
+ Hits 31084 33590 +2506
+ Misses 18233 16513 -1720
+ Partials 209 134 -75
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.61% <0.00%> (?)` | |
| javascript | `60.75% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `64.53% <ø> (+0.45%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `83.95% <100.00%> (-0.86%)` | :arrow_down: |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `83.92% <0.00%> (-1.79%)` | :arrow_down: |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `94.54% <0.00%> (-1.20%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `74.71% <0.00%> (-0.87%)` | :arrow_down: |
| [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `76.08% <0.00%> (-0.84%)` | :arrow_down: |
| [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | `60.41% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.86% <0.00%> (-0.60%)` | :arrow_down: |
| [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `66.14% <0.00%> (-0.53%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.35% <0.00%> (-0.32%)` | :arrow_down: |
| ... and [194 more](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=footer). Last update [75f927b...d63ceb5](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12471: fix: styling for change dataset confirmation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12471:
URL: https://github.com/apache/superset/pull/12471#issuecomment-759077947
# [Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=h1) Report
> Merging [#12471](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=desc) (d63ceb5) into [master](https://codecov.io/gh/apache/superset/commit/75f927b9ebe4174d9af37ac4d4ce1a043cee77f1?el=desc) (75f927b) will **increase** coverage by `4.18%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12471 +/- ##
==========================================
+ Coverage 62.76% 66.94% +4.18%
==========================================
Files 1015 1015
Lines 49526 50237 +711
Branches 5080 5130 +50
==========================================
+ Hits 31084 33633 +2549
+ Misses 18233 16474 -1759
+ Partials 209 130 -79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.99% <0.00%> (?)` | |
| javascript | `60.75% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `64.53% <ø> (+0.45%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `83.95% <100.00%> (-0.86%)` | :arrow_down: |
| [...rontend/src/explore/components/DatasourcePanel.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhc291cmNlUGFuZWwudHN4) | `83.92% <0.00%> (-1.79%)` | :arrow_down: |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `94.54% <0.00%> (-1.20%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `74.71% <0.00%> (-0.87%)` | :arrow_down: |
| [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `76.08% <0.00%> (-0.84%)` | :arrow_down: |
| [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | `60.41% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.86% <0.00%> (-0.60%)` | :arrow_down: |
| [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `66.14% <0.00%> (-0.53%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.35% <0.00%> (-0.32%)` | :arrow_down: |
| ... and [195 more](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=footer). Last update [75f927b...d63ceb5](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12471: fix: styling for change dataset confirmation
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12471:
URL: https://github.com/apache/superset/pull/12471#issuecomment-759077947
# [Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=h1) Report
> Merging [#12471](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=desc) (d63ceb5) into [master](https://codecov.io/gh/apache/superset/commit/75f927b9ebe4174d9af37ac4d4ce1a043cee77f1?el=desc) (75f927b) will **increase** coverage by `0.08%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12471 +/- ##
==========================================
+ Coverage 62.76% 62.84% +0.08%
==========================================
Files 1015 1015
Lines 49526 50075 +549
Branches 5080 5081 +1
==========================================
+ Hits 31084 31472 +388
- Misses 18233 18394 +161
Partials 209 209
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.75% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `64.19% <ø> (+0.11%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `85.00% <100.00%> (+0.18%)` | :arrow_up: |
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `54.61% <0.00%> (-29.24%)` | :arrow_down: |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `94.54% <0.00%> (-1.20%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.86% <0.00%> (-0.60%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `91.57% <0.00%> (-0.41%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.58% <0.00%> (-0.28%)` | :arrow_down: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.40% <0.00%> (+1.12%)` | :arrow_up: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `88.18% <0.00%> (+1.60%)` | :arrow_up: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `88.23% <0.00%> (+5.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=footer). Last update [75f927b...d63ceb5](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12471: fix: styling for change dataset confirmation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12471:
URL: https://github.com/apache/superset/pull/12471#issuecomment-759077947
# [Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=h1) Report
> Merging [#12471](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=desc) (d63ceb5) into [master](https://codecov.io/gh/apache/superset/commit/75f927b9ebe4174d9af37ac4d4ce1a043cee77f1?el=desc) (75f927b) will **increase** coverage by `4.36%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12471 +/- ##
==========================================
+ Coverage 62.76% 67.12% +4.36%
==========================================
Files 1015 1015
Lines 49526 50238 +712
Branches 5080 5130 +50
==========================================
+ Hits 31084 33722 +2638
+ Misses 18233 16386 -1847
+ Partials 209 130 -79
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `51.30% <0.00%> (?)` | |
| javascript | `60.75% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `64.53% <ø> (+0.45%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `83.95% <100.00%> (-0.86%)` | :arrow_down: |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `94.54% <0.00%> (-1.20%)` | :arrow_down: |
| [...ews/CRUD/annotationlayers/AnnotationLayerModal.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbmxheWVycy9Bbm5vdGF0aW9uTGF5ZXJNb2RhbC50c3g=) | `74.71% <0.00%> (-0.87%)` | :arrow_down: |
| [...ntend/src/views/CRUD/annotation/AnnotationList.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTGlzdC50c3g=) | `76.08% <0.00%> (-0.84%)` | :arrow_down: |
| [...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9TYXZlZFF1ZXJpZXMudHN4) | `60.41% <0.00%> (-0.64%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.86% <0.00%> (-0.60%)` | :arrow_down: |
| [...tend/src/views/CRUD/annotation/AnnotationModal.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYW5ub3RhdGlvbi9Bbm5vdGF0aW9uTW9kYWwudHN4) | `66.14% <0.00%> (-0.53%)` | :arrow_down: |
| [...erset-frontend/src/SqlLab/components/ResultSet.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9jb21wb25lbnRzL1Jlc3VsdFNldC50c3g=) | `66.35% <0.00%> (-0.32%)` | :arrow_down: |
| [...frontend/src/views/CRUD/alert/AlertReportModal.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvYWxlcnQvQWxlcnRSZXBvcnRNb2RhbC50c3g=) | `46.78% <0.00%> (-0.24%)` | :arrow_down: |
| ... and [195 more](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=footer). Last update [75f927b...d63ceb5](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] adam-stasiak commented on pull request #12471: fix: styling for change dataset confirmation
Posted by GitBox <gi...@apache.org>.
adam-stasiak commented on pull request #12471:
URL: https://github.com/apache/superset/pull/12471#issuecomment-759484951
Confirm modal should be 432 or the green area 432? You can see that exact width of modal is 408


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12471: fix: styling for change dataset confirmation
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12471:
URL: https://github.com/apache/superset/pull/12471#issuecomment-759077947
# [Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=h1) Report
> Merging [#12471](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=desc) (d63ceb5) into [master](https://codecov.io/gh/apache/superset/commit/75f927b9ebe4174d9af37ac4d4ce1a043cee77f1?el=desc) (75f927b) will **increase** coverage by `0.29%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12471 +/- ##
==========================================
+ Coverage 62.76% 63.05% +0.29%
==========================================
Files 1015 1015
Lines 49526 50075 +549
Branches 5080 5081 +1
==========================================
+ Hits 31084 31575 +491
- Misses 18233 18291 +58
Partials 209 209
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `60.75% <100.00%> (+<0.01%)` | :arrow_up: |
| python | `64.53% <ø> (+0.45%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...-frontend/src/datasource/ChangeDatasourceModal.tsx](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvQ2hhbmdlRGF0YXNvdXJjZU1vZGFsLnRzeA==) | `85.00% <100.00%> (+0.18%)` | :arrow_up: |
| [superset/css\_templates/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `94.54% <0.00%> (-1.20%)` | :arrow_down: |
| [superset/charts/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2FwaS5weQ==) | `80.86% <0.00%> (-0.60%)` | :arrow_down: |
| [superset/databases/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2FwaS5weQ==) | `92.11% <0.00%> (+0.13%)` | :arrow_up: |
| [superset/datasets/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvYXBpLnB5) | `92.40% <0.00%> (+1.12%)` | :arrow_up: |
| [superset/dashboards/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGFzaGJvYXJkcy9hcGkucHk=) | `88.18% <0.00%> (+1.60%)` | :arrow_up: |
| [superset/annotation\_layers/api.py](https://codecov.io/gh/apache/superset/pull/12471/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYXBpLnB5) | `88.23% <0.00%> (+5.04%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=footer). Last update [75f927b...d63ceb5](https://codecov.io/gh/apache/superset/pull/12471?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org