You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Rajat Khandelwal <ra...@gmail.com> on 2015/03/16 14:02:53 UTC
Review Request 32100: LENS-282: optimize add partitions
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32100/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-282
https://issues.apache.org/jira/browse/LENS-282
Repository: lens
Description
-------
add partitions
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec082622ca88a8599e9426befab0837a8704
lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java efc4d64ed1d63e8b85c53717579acd998ee3ae32
lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java 84293f48636829cc0f2a80cb62f552878319c359
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java d442bc0859b17a3b284a5456f7e464be5c8f4883
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 30921df3ebf54684b1060a288d2629647b0a143d
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e92e1a23ff67d3a24a4566f0f886cfb86b3
lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0027e64997fd8a7a367a99c11d3017d334f2e631
lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java de2f8652124f811c87a9031412ac4aa09eb08830
Diff: https://reviews.apache.org/r/32100/diff/
Testing
-------
Added some new test cases. All test cases pass.
Thanks,
Rajat Khandelwal
Re: Review Request 32100: LENS-282: optimize add partitions
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 17, 2015, 1:30 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java, line 1946
> > <https://reviews.apache.org/r/32100/diff/4/?file=896084#file896084line1946>
> >
> > Why would dimension have more than one time dimension? We allow only one time dimension for snapshotting time dimension
I saw no such restrictions imposed by the existing code. In the test case I added, I'm very easily able to create dimension. It might be a rare use case but I don't think we should restrict dimensions' time parts.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32100/#review76715
-----------------------------------------------------------
On March 18, 2015, 1:45 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32100/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 1:45 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-282
> https://issues.apache.org/jira/browse/LENS-282
>
>
> Repository: lens
>
>
> Description
> -------
>
> add partitions
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec082622ca88a8599e9426befab0837a8704
> lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java efc4d64ed1d63e8b85c53717579acd998ee3ae32
> lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java 84293f48636829cc0f2a80cb62f552878319c359
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java d442bc0859b17a3b284a5456f7e464be5c8f4883
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 30921df3ebf54684b1060a288d2629647b0a143d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c79c9ceebd6bab9150793214e3526c5c2f5d2f7c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e92e1a23ff67d3a24a4566f0f886cfb86b3
> lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java de2f8652124f811c87a9031412ac4aa09eb08830
>
> Diff: https://reviews.apache.org/r/32100/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
> [INFO] Lens .............................................. SUCCESS [1.834s]
> [INFO] Lens API .......................................... SUCCESS [4.747s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.213s]
> [INFO] Lens Cube ......................................... SUCCESS [2:20.758s]
> [INFO] Lens DB storage ................................... SUCCESS [10.204s]
> [INFO] Lens Query Library ................................ SUCCESS [5.156s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:34.772s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [26.337s]
> [INFO] Lens Server ....................................... SUCCESS [4:21.275s]
> [INFO] Lens client ....................................... SUCCESS [21.300s]
> [INFO] Lens CLI .......................................... SUCCESS [1:49.842s]
> [INFO] Lens Examples ..................................... SUCCESS [0.946s]
> [INFO] Lens Distribution ................................. SUCCESS [9.783s]
> [INFO] Lens ML Lib ....................................... SUCCESS [44.071s]
> [INFO] Lens Regression ................................... SUCCESS [0.483s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:20.811s
> [INFO] Finished at: Mon Mar 16 16:40:09 UTC 2015
> [INFO] Final Memory: 109M/1181M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32100: LENS-282: optimize add partitions
Posted by Rajat Khandelwal <ra...@gmail.com>.
> On March 17, 2015, 1:30 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java, line 33
> > <https://reviews.apache.org/r/32100/diff/4/?file=896079#file896079line33>
> >
> > Dont remove the hooks for single partition addition
Would be painful for the implementors to implement two methods. Most of the code will be same anyway in their implementations
> On March 17, 2015, 1:30 p.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java, line 720
> > <https://reviews.apache.org/r/32100/diff/4/?file=896077#file896077line720>
> >
> > We might always have single partition getting added for dimtable storages. Multiple partitions might never be added. We can remove a lot of code with respect to that. We can do a follow up, not blocking this patch for this.
That is taken care in `addPartition` method. This method doesn't need to care for that.
- Rajat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32100/#review76715
-----------------------------------------------------------
On March 16, 2015, 10:52 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32100/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 10:52 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-282
> https://issues.apache.org/jira/browse/LENS-282
>
>
> Repository: lens
>
>
> Description
> -------
>
> add partitions
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec082622ca88a8599e9426befab0837a8704
> lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java efc4d64ed1d63e8b85c53717579acd998ee3ae32
> lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java 84293f48636829cc0f2a80cb62f552878319c359
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java d442bc0859b17a3b284a5456f7e464be5c8f4883
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 30921df3ebf54684b1060a288d2629647b0a143d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c79c9ceebd6bab9150793214e3526c5c2f5d2f7c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e92e1a23ff67d3a24a4566f0f886cfb86b3
> lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java de2f8652124f811c87a9031412ac4aa09eb08830
>
> Diff: https://reviews.apache.org/r/32100/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
> [INFO] Lens .............................................. SUCCESS [1.834s]
> [INFO] Lens API .......................................... SUCCESS [4.747s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.213s]
> [INFO] Lens Cube ......................................... SUCCESS [2:20.758s]
> [INFO] Lens DB storage ................................... SUCCESS [10.204s]
> [INFO] Lens Query Library ................................ SUCCESS [5.156s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:34.772s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [26.337s]
> [INFO] Lens Server ....................................... SUCCESS [4:21.275s]
> [INFO] Lens client ....................................... SUCCESS [21.300s]
> [INFO] Lens CLI .......................................... SUCCESS [1:49.842s]
> [INFO] Lens Examples ..................................... SUCCESS [0.946s]
> [INFO] Lens Distribution ................................. SUCCESS [9.783s]
> [INFO] Lens ML Lib ....................................... SUCCESS [44.071s]
> [INFO] Lens Regression ................................... SUCCESS [0.483s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:20.811s
> [INFO] Finished at: Mon Mar 16 16:40:09 UTC 2015
> [INFO] Final Memory: 109M/1181M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32100: LENS-282: optimize add partitions
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32100/#review76715
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java
<https://reviews.apache.org/r/32100/#comment124341>
We might always have single partition getting added for dimtable storages. Multiple partitions might never be added. We can remove a lot of code with respect to that. We can do a follow up, not blocking this patch for this.
lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java
<https://reviews.apache.org/r/32100/#comment124345>
Dont remove the hooks for single partition addition
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java
<https://reviews.apache.org/r/32100/#comment124346>
Dont remove the ability to add single partition
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java
<https://reviews.apache.org/r/32100/#comment124347>
Why would dimension have more than one time dimension? We allow only one time dimension for snapshotting time dimension
- Amareshwari Sriramadasu
On March 16, 2015, 5:22 p.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32100/
> -----------------------------------------------------------
>
> (Updated March 16, 2015, 5:22 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-282
> https://issues.apache.org/jira/browse/LENS-282
>
>
> Repository: lens
>
>
> Description
> -------
>
> add partitions
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec082622ca88a8599e9426befab0837a8704
> lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java efc4d64ed1d63e8b85c53717579acd998ee3ae32
> lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java 84293f48636829cc0f2a80cb62f552878319c359
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java d442bc0859b17a3b284a5456f7e464be5c8f4883
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 30921df3ebf54684b1060a288d2629647b0a143d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c79c9ceebd6bab9150793214e3526c5c2f5d2f7c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e92e1a23ff67d3a24a4566f0f886cfb86b3
> lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java de2f8652124f811c87a9031412ac4aa09eb08830
>
> Diff: https://reviews.apache.org/r/32100/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
> [INFO] Lens .............................................. SUCCESS [1.834s]
> [INFO] Lens API .......................................... SUCCESS [4.747s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.213s]
> [INFO] Lens Cube ......................................... SUCCESS [2:20.758s]
> [INFO] Lens DB storage ................................... SUCCESS [10.204s]
> [INFO] Lens Query Library ................................ SUCCESS [5.156s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:34.772s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [26.337s]
> [INFO] Lens Server ....................................... SUCCESS [4:21.275s]
> [INFO] Lens client ....................................... SUCCESS [21.300s]
> [INFO] Lens CLI .......................................... SUCCESS [1:49.842s]
> [INFO] Lens Examples ..................................... SUCCESS [0.946s]
> [INFO] Lens Distribution ................................. SUCCESS [9.783s]
> [INFO] Lens ML Lib ....................................... SUCCESS [44.071s]
> [INFO] Lens Regression ................................... SUCCESS [0.483s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:20.811s
> [INFO] Finished at: Mon Mar 16 16:40:09 UTC 2015
> [INFO] Final Memory: 109M/1181M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32100: LENS-282: optimize add partitions
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32100/#review77037
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On March 18, 2015, 8:15 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32100/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 8:15 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-282
> https://issues.apache.org/jira/browse/LENS-282
>
>
> Repository: lens
>
>
> Description
> -------
>
> add partitions
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec082622ca88a8599e9426befab0837a8704
> lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java efc4d64ed1d63e8b85c53717579acd998ee3ae32
> lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java 84293f48636829cc0f2a80cb62f552878319c359
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java d442bc0859b17a3b284a5456f7e464be5c8f4883
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 30921df3ebf54684b1060a288d2629647b0a143d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c79c9ceebd6bab9150793214e3526c5c2f5d2f7c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e92e1a23ff67d3a24a4566f0f886cfb86b3
> lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java de2f8652124f811c87a9031412ac4aa09eb08830
>
> Diff: https://reviews.apache.org/r/32100/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
> [INFO] Lens .............................................. SUCCESS [1.834s]
> [INFO] Lens API .......................................... SUCCESS [4.747s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.213s]
> [INFO] Lens Cube ......................................... SUCCESS [2:20.758s]
> [INFO] Lens DB storage ................................... SUCCESS [10.204s]
> [INFO] Lens Query Library ................................ SUCCESS [5.156s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:34.772s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [26.337s]
> [INFO] Lens Server ....................................... SUCCESS [4:21.275s]
> [INFO] Lens client ....................................... SUCCESS [21.300s]
> [INFO] Lens CLI .......................................... SUCCESS [1:49.842s]
> [INFO] Lens Examples ..................................... SUCCESS [0.946s]
> [INFO] Lens Distribution ................................. SUCCESS [9.783s]
> [INFO] Lens ML Lib ....................................... SUCCESS [44.071s]
> [INFO] Lens Regression ................................... SUCCESS [0.483s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:20.811s
> [INFO] Finished at: Mon Mar 16 16:40:09 UTC 2015
> [INFO] Final Memory: 109M/1181M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32100: LENS-282: optimize add partitions
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On March 19, 2015, 7:27 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java, line 296
> > <https://reviews.apache.org/r/32100/diff/6/?file=898862#file898862line296>
> >
> > Why are there so many latest parts?
Ignore. I see it is keeping a map of latest part to index in partlist
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32100/#review77028
-----------------------------------------------------------
On March 18, 2015, 8:15 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32100/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 8:15 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-282
> https://issues.apache.org/jira/browse/LENS-282
>
>
> Repository: lens
>
>
> Description
> -------
>
> add partitions
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec082622ca88a8599e9426befab0837a8704
> lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java efc4d64ed1d63e8b85c53717579acd998ee3ae32
> lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java 84293f48636829cc0f2a80cb62f552878319c359
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java d442bc0859b17a3b284a5456f7e464be5c8f4883
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 30921df3ebf54684b1060a288d2629647b0a143d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c79c9ceebd6bab9150793214e3526c5c2f5d2f7c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e92e1a23ff67d3a24a4566f0f886cfb86b3
> lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java de2f8652124f811c87a9031412ac4aa09eb08830
>
> Diff: https://reviews.apache.org/r/32100/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
> [INFO] Lens .............................................. SUCCESS [1.834s]
> [INFO] Lens API .......................................... SUCCESS [4.747s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.213s]
> [INFO] Lens Cube ......................................... SUCCESS [2:20.758s]
> [INFO] Lens DB storage ................................... SUCCESS [10.204s]
> [INFO] Lens Query Library ................................ SUCCESS [5.156s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:34.772s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [26.337s]
> [INFO] Lens Server ....................................... SUCCESS [4:21.275s]
> [INFO] Lens client ....................................... SUCCESS [21.300s]
> [INFO] Lens CLI .......................................... SUCCESS [1:49.842s]
> [INFO] Lens Examples ..................................... SUCCESS [0.946s]
> [INFO] Lens Distribution ................................. SUCCESS [9.783s]
> [INFO] Lens ML Lib ....................................... SUCCESS [44.071s]
> [INFO] Lens Regression ................................... SUCCESS [0.483s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:20.811s
> [INFO] Finished at: Mon Mar 16 16:40:09 UTC 2015
> [INFO] Final Memory: 109M/1181M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32100: LENS-282: optimize add partitions
Posted by Amareshwari Sriramadasu <am...@apache.org>.
> On March 19, 2015, 7:27 a.m., Amareshwari Sriramadasu wrote:
> > lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java, line 258
> > <https://reviews.apache.org/r/32100/diff/6/?file=898862#file898862line258>
> >
> > call param fact as factOrDimtable
Will do the change in LENS-405
- Amareshwari
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32100/#review77028
-----------------------------------------------------------
On March 18, 2015, 8:15 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32100/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 8:15 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-282
> https://issues.apache.org/jira/browse/LENS-282
>
>
> Repository: lens
>
>
> Description
> -------
>
> add partitions
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec082622ca88a8599e9426befab0837a8704
> lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java efc4d64ed1d63e8b85c53717579acd998ee3ae32
> lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java 84293f48636829cc0f2a80cb62f552878319c359
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java d442bc0859b17a3b284a5456f7e464be5c8f4883
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 30921df3ebf54684b1060a288d2629647b0a143d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c79c9ceebd6bab9150793214e3526c5c2f5d2f7c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e92e1a23ff67d3a24a4566f0f886cfb86b3
> lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java de2f8652124f811c87a9031412ac4aa09eb08830
>
> Diff: https://reviews.apache.org/r/32100/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
> [INFO] Lens .............................................. SUCCESS [1.834s]
> [INFO] Lens API .......................................... SUCCESS [4.747s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.213s]
> [INFO] Lens Cube ......................................... SUCCESS [2:20.758s]
> [INFO] Lens DB storage ................................... SUCCESS [10.204s]
> [INFO] Lens Query Library ................................ SUCCESS [5.156s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:34.772s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [26.337s]
> [INFO] Lens Server ....................................... SUCCESS [4:21.275s]
> [INFO] Lens client ....................................... SUCCESS [21.300s]
> [INFO] Lens CLI .......................................... SUCCESS [1:49.842s]
> [INFO] Lens Examples ..................................... SUCCESS [0.946s]
> [INFO] Lens Distribution ................................. SUCCESS [9.783s]
> [INFO] Lens ML Lib ....................................... SUCCESS [44.071s]
> [INFO] Lens Regression ................................... SUCCESS [0.483s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:20.811s
> [INFO] Finished at: Mon Mar 16 16:40:09 UTC 2015
> [INFO] Final Memory: 109M/1181M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32100: LENS-282: optimize add partitions
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32100/#review77028
-----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java
<https://reviews.apache.org/r/32100/#comment124817>
call param fact as factOrDimtable
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java
<https://reviews.apache.org/r/32100/#comment124818>
Why are there so many latest parts?
- Amareshwari Sriramadasu
On March 18, 2015, 8:15 a.m., Rajat Khandelwal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32100/
> -----------------------------------------------------------
>
> (Updated March 18, 2015, 8:15 a.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-282
> https://issues.apache.org/jira/browse/LENS-282
>
>
> Repository: lens
>
>
> Description
> -------
>
> add partitions
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec082622ca88a8599e9426befab0837a8704
> lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java efc4d64ed1d63e8b85c53717579acd998ee3ae32
> lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java 84293f48636829cc0f2a80cb62f552878319c359
> lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java d442bc0859b17a3b284a5456f7e464be5c8f4883
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 30921df3ebf54684b1060a288d2629647b0a143d
> lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c79c9ceebd6bab9150793214e3526c5c2f5d2f7c
> lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e92e1a23ff67d3a24a4566f0f886cfb86b3
> lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java de2f8652124f811c87a9031412ac4aa09eb08830
>
> Diff: https://reviews.apache.org/r/32100/diff/
>
>
> Testing
> -------
>
> [INFO] ------------------------------------------------------------------------
> [INFO] Reactor Summary:
> [INFO]
> [INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
> [INFO] Lens .............................................. SUCCESS [1.834s]
> [INFO] Lens API .......................................... SUCCESS [4.747s]
> [INFO] Lens API for server and extensions ................ SUCCESS [6.213s]
> [INFO] Lens Cube ......................................... SUCCESS [2:20.758s]
> [INFO] Lens DB storage ................................... SUCCESS [10.204s]
> [INFO] Lens Query Library ................................ SUCCESS [5.156s]
> [INFO] Lens Hive Driver .................................. SUCCESS [2:34.772s]
> [INFO] Lens Driver for JDBC .............................. SUCCESS [26.337s]
> [INFO] Lens Server ....................................... SUCCESS [4:21.275s]
> [INFO] Lens client ....................................... SUCCESS [21.300s]
> [INFO] Lens CLI .......................................... SUCCESS [1:49.842s]
> [INFO] Lens Examples ..................................... SUCCESS [0.946s]
> [INFO] Lens Distribution ................................. SUCCESS [9.783s]
> [INFO] Lens ML Lib ....................................... SUCCESS [44.071s]
> [INFO] Lens Regression ................................... SUCCESS [0.483s]
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:20.811s
> [INFO] Finished at: Mon Mar 16 16:40:09 UTC 2015
> [INFO] Final Memory: 109M/1181M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Rajat Khandelwal
>
>
Re: Review Request 32100: LENS-282: optimize add partitions
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32100/
-----------------------------------------------------------
(Updated March 18, 2015, 1:45 p.m.)
Review request for lens.
Bugs: LENS-282
https://issues.apache.org/jira/browse/LENS-282
Repository: lens
Description
-------
add partitions
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec082622ca88a8599e9426befab0837a8704
lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java efc4d64ed1d63e8b85c53717579acd998ee3ae32
lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java 84293f48636829cc0f2a80cb62f552878319c359
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java d442bc0859b17a3b284a5456f7e464be5c8f4883
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 30921df3ebf54684b1060a288d2629647b0a143d
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c79c9ceebd6bab9150793214e3526c5c2f5d2f7c
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e92e1a23ff67d3a24a4566f0f886cfb86b3
lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java de2f8652124f811c87a9031412ac4aa09eb08830
Diff: https://reviews.apache.org/r/32100/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
[INFO] Lens .............................................. SUCCESS [1.834s]
[INFO] Lens API .......................................... SUCCESS [4.747s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.213s]
[INFO] Lens Cube ......................................... SUCCESS [2:20.758s]
[INFO] Lens DB storage ................................... SUCCESS [10.204s]
[INFO] Lens Query Library ................................ SUCCESS [5.156s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:34.772s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [26.337s]
[INFO] Lens Server ....................................... SUCCESS [4:21.275s]
[INFO] Lens client ....................................... SUCCESS [21.300s]
[INFO] Lens CLI .......................................... SUCCESS [1:49.842s]
[INFO] Lens Examples ..................................... SUCCESS [0.946s]
[INFO] Lens Distribution ................................. SUCCESS [9.783s]
[INFO] Lens ML Lib ....................................... SUCCESS [44.071s]
[INFO] Lens Regression ................................... SUCCESS [0.483s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:20.811s
[INFO] Finished at: Mon Mar 16 16:40:09 UTC 2015
[INFO] Final Memory: 109M/1181M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 32100: LENS-282: optimize add partitions
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32100/
-----------------------------------------------------------
(Updated March 18, 2015, 1:42 p.m.)
Review request for lens.
Bugs: LENS-282
https://issues.apache.org/jira/browse/LENS-282
Repository: lens
Description
-------
add partitions
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec082622ca88a8599e9426befab0837a8704
lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java efc4d64ed1d63e8b85c53717579acd998ee3ae32
lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java 84293f48636829cc0f2a80cb62f552878319c359
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java d442bc0859b17a3b284a5456f7e464be5c8f4883
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 30921df3ebf54684b1060a288d2629647b0a143d
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c79c9ceebd6bab9150793214e3526c5c2f5d2f7c
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e92e1a23ff67d3a24a4566f0f886cfb86b3
lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java de2f8652124f811c87a9031412ac4aa09eb08830
Diff: https://reviews.apache.org/r/32100/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
[INFO] Lens .............................................. SUCCESS [1.834s]
[INFO] Lens API .......................................... SUCCESS [4.747s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.213s]
[INFO] Lens Cube ......................................... SUCCESS [2:20.758s]
[INFO] Lens DB storage ................................... SUCCESS [10.204s]
[INFO] Lens Query Library ................................ SUCCESS [5.156s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:34.772s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [26.337s]
[INFO] Lens Server ....................................... SUCCESS [4:21.275s]
[INFO] Lens client ....................................... SUCCESS [21.300s]
[INFO] Lens CLI .......................................... SUCCESS [1:49.842s]
[INFO] Lens Examples ..................................... SUCCESS [0.946s]
[INFO] Lens Distribution ................................. SUCCESS [9.783s]
[INFO] Lens ML Lib ....................................... SUCCESS [44.071s]
[INFO] Lens Regression ................................... SUCCESS [0.483s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:20.811s
[INFO] Finished at: Mon Mar 16 16:40:09 UTC 2015
[INFO] Final Memory: 109M/1181M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 32100: LENS-282: optimize add partitions
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32100/
-----------------------------------------------------------
(Updated March 16, 2015, 10:52 p.m.)
Review request for lens.
Bugs: LENS-282
https://issues.apache.org/jira/browse/LENS-282
Repository: lens
Description
-------
add partitions
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec082622ca88a8599e9426befab0837a8704
lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java efc4d64ed1d63e8b85c53717579acd998ee3ae32
lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java 84293f48636829cc0f2a80cb62f552878319c359
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java d442bc0859b17a3b284a5456f7e464be5c8f4883
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 30921df3ebf54684b1060a288d2629647b0a143d
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c79c9ceebd6bab9150793214e3526c5c2f5d2f7c
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e92e1a23ff67d3a24a4566f0f886cfb86b3
lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java de2f8652124f811c87a9031412ac4aa09eb08830
Diff: https://reviews.apache.org/r/32100/diff/
Testing
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
[INFO] Lens .............................................. SUCCESS [1.834s]
[INFO] Lens API .......................................... SUCCESS [4.747s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.213s]
[INFO] Lens Cube ......................................... SUCCESS [2:20.758s]
[INFO] Lens DB storage ................................... SUCCESS [10.204s]
[INFO] Lens Query Library ................................ SUCCESS [5.156s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:34.772s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [26.337s]
[INFO] Lens Server ....................................... SUCCESS [4:21.275s]
[INFO] Lens client ....................................... SUCCESS [21.300s]
[INFO] Lens CLI .......................................... SUCCESS [1:49.842s]
[INFO] Lens Examples ..................................... SUCCESS [0.946s]
[INFO] Lens Distribution ................................. SUCCESS [9.783s]
[INFO] Lens ML Lib ....................................... SUCCESS [44.071s]
[INFO] Lens Regression ................................... SUCCESS [0.483s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:20.811s
[INFO] Finished at: Mon Mar 16 16:40:09 UTC 2015
[INFO] Final Memory: 109M/1181M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 32100: LENS-282: optimize add partitions
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32100/
-----------------------------------------------------------
(Updated March 16, 2015, 10:40 p.m.)
Review request for lens.
Bugs: LENS-282
https://issues.apache.org/jira/browse/LENS-282
Repository: lens
Description
-------
add partitions
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec082622ca88a8599e9426befab0837a8704
lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java efc4d64ed1d63e8b85c53717579acd998ee3ae32
lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java 84293f48636829cc0f2a80cb62f552878319c359
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java d442bc0859b17a3b284a5456f7e464be5c8f4883
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 30921df3ebf54684b1060a288d2629647b0a143d
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c79c9ceebd6bab9150793214e3526c5c2f5d2f7c
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e92e1a23ff67d3a24a4566f0f886cfb86b3
lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0027e64997fd8a7a367a99c11d3017d334f2e631
lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java de2f8652124f811c87a9031412ac4aa09eb08830
Diff: https://reviews.apache.org/r/32100/diff/
Testing (updated)
-------
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] Lens Checkstyle Rules ............................. SUCCESS [2.154s]
[INFO] Lens .............................................. SUCCESS [1.834s]
[INFO] Lens API .......................................... SUCCESS [4.747s]
[INFO] Lens API for server and extensions ................ SUCCESS [6.213s]
[INFO] Lens Cube ......................................... SUCCESS [2:20.758s]
[INFO] Lens DB storage ................................... SUCCESS [10.204s]
[INFO] Lens Query Library ................................ SUCCESS [5.156s]
[INFO] Lens Hive Driver .................................. SUCCESS [2:34.772s]
[INFO] Lens Driver for JDBC .............................. SUCCESS [26.337s]
[INFO] Lens Server ....................................... SUCCESS [4:21.275s]
[INFO] Lens client ....................................... SUCCESS [21.300s]
[INFO] Lens CLI .......................................... SUCCESS [1:49.842s]
[INFO] Lens Examples ..................................... SUCCESS [0.946s]
[INFO] Lens Distribution ................................. SUCCESS [9.783s]
[INFO] Lens ML Lib ....................................... SUCCESS [44.071s]
[INFO] Lens Regression ................................... SUCCESS [0.483s]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:20.811s
[INFO] Finished at: Mon Mar 16 16:40:09 UTC 2015
[INFO] Final Memory: 109M/1181M
[INFO] ------------------------------------------------------------------------
Thanks,
Rajat Khandelwal
Re: Review Request 32100: LENS-282: optimize add partitions
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32100/
-----------------------------------------------------------
(Updated March 16, 2015, 10:02 p.m.)
Review request for lens.
Bugs: LENS-282
https://issues.apache.org/jira/browse/LENS-282
Repository: lens
Description
-------
add partitions
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec082622ca88a8599e9426befab0837a8704
lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java efc4d64ed1d63e8b85c53717579acd998ee3ae32
lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java 84293f48636829cc0f2a80cb62f552878319c359
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java d442bc0859b17a3b284a5456f7e464be5c8f4883
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 30921df3ebf54684b1060a288d2629647b0a143d
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c79c9ceebd6bab9150793214e3526c5c2f5d2f7c
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e92e1a23ff67d3a24a4566f0f886cfb86b3
lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0027e64997fd8a7a367a99c11d3017d334f2e631
lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java de2f8652124f811c87a9031412ac4aa09eb08830
Diff: https://reviews.apache.org/r/32100/diff/
Testing
-------
Added some new test cases. All test cases pass.
Thanks,
Rajat Khandelwal
Re: Review Request 32100: LENS-282: optimize add partitions
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32100/
-----------------------------------------------------------
(Updated March 16, 2015, 8:01 p.m.)
Review request for lens.
Bugs: LENS-282
https://issues.apache.org/jira/browse/LENS-282
Repository: lens
Description
-------
add partitions
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java 10e8ec082622ca88a8599e9426befab0837a8704
lens-cube/src/main/java/org/apache/lens/cube/metadata/HDFSStorage.java efc4d64ed1d63e8b85c53717579acd998ee3ae32
lens-cube/src/main/java/org/apache/lens/cube/metadata/PartitionMetahook.java 84293f48636829cc0f2a80cb62f552878319c359
lens-cube/src/main/java/org/apache/lens/cube/metadata/Storage.java f1692b2c0dac84f9b3c8acb2195ebf4ddc6da8ad
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/EndsAndHolesPartitionTimeline.java d442bc0859b17a3b284a5456f7e464be5c8f4883
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/PartitionTimeline.java 30921df3ebf54684b1060a288d2629647b0a143d
lens-cube/src/main/java/org/apache/lens/cube/metadata/timeline/StoreAllPartitionTimeline.java c79c9ceebd6bab9150793214e3526c5c2f5d2f7c
lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java 33224e92e1a23ff67d3a24a4566f0f886cfb86b3
lens-cube/src/test/java/org/apache/lens/cube/metadata/timeline/TestPartitionTimelines.java 0027e64997fd8a7a367a99c11d3017d334f2e631
lens-storage-db/src/main/java/org/apache/lens/storage/db/DBStorage.java de2f8652124f811c87a9031412ac4aa09eb08830
Diff: https://reviews.apache.org/r/32100/diff/
Testing
-------
Added some new test cases. All test cases pass.
Thanks,
Rajat Khandelwal