You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2019/07/19 22:06:32 UTC

[GitHub] [incubator-mxnet] haojin2 commented on a change in pull request #14940: Fix warnings

haojin2 commented on a change in pull request #14940: Fix warnings
URL: https://github.com/apache/incubator-mxnet/pull/14940#discussion_r305538906
 
 

 ##########
 File path: src/common/exec_utils.h
 ##########
 @@ -449,177 +190,27 @@ inline void HandleInferStorageTypeError(const size_t num_forward_inputs,
  * Shareable storages include both default storage and row_sparse storage
  * if enable_row_sparse_sharing is `True`, otherwise default storage only.
  */
-inline NDArray ReshapeOrCreate(const std::string& name,
+NDArray ReshapeOrCreate(const std::string& name,
                                const mxnet::TShape& dest_arg_shape,
 
 Review comment:
   At all applicable places.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services