You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/23 21:53:26 UTC

[GitHub] [spark] zero323 commented on pull request #30094: [SPARK-33003][PYTHON][DOCS] Add type hints guidelines to the documentation

zero323 commented on pull request #30094:
URL: https://github.com/apache/spark/pull/30094#issuecomment-715606779


   Thanks for checking this @HyukjinKwon! I think it is ready for review ‒ I've modified grammar as requested and section about validating.
   
   As of user part, I decided against adding it for now. I have some hints, but these seem to be too localized (specific editors, common typing issues), while for most of the users, benefits will be mostly transparent. Maybe we could add a short guide for different environments (I have [this answer](https://stackoverflow.com/a/34714207) on Stack, which seems to be weirdly popular) and add some typing notes there?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org