You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nifi.apache.org by fg...@apache.org on 2023/03/21 15:59:44 UTC

[nifi-minifi-cpp] 02/03: MINIFICPP-2075 Fix flaky PutTCPTests testcase

This is an automated email from the ASF dual-hosted git repository.

fgerlits pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/nifi-minifi-cpp.git

commit be34911e89118aaa5071da91b4b9cea71e5cb2da
Author: Martin Zink <ma...@apache.org>
AuthorDate: Thu Mar 9 17:15:37 2023 +0100

    MINIFICPP-2075 Fix flaky PutTCPTests testcase
    
    Signed-off-by: Ferenc Gerlits <fg...@gmail.com>
    This closes #1536
---
 extensions/standard-processors/tests/unit/PutTCPTests.cpp | 14 --------------
 1 file changed, 14 deletions(-)

diff --git a/extensions/standard-processors/tests/unit/PutTCPTests.cpp b/extensions/standard-processors/tests/unit/PutTCPTests.cpp
index 524c451b2..fa8f3c151 100644
--- a/extensions/standard-processors/tests/unit/PutTCPTests.cpp
+++ b/extensions/standard-processors/tests/unit/PutTCPTests.cpp
@@ -352,10 +352,6 @@ TEST_CASE("PutTCP test invalid host", "[PutTCP]") {
   test_fixture.setPutTCPPort(1235);
   test_fixture.setHostname("invalid_hostname");
   trigger_expect_failure(test_fixture, "message for invalid host");
-
-  CHECK((LogTestController::getInstance().contains("Host not found", 0ms)
-      || LogTestController::getInstance().contains("No such host is known", 0ms)
-      || LogTestController::getInstance().contains("A connection attempt failed because the connected party did not properly respond", 0ms)));
 }
 
 TEST_CASE("PutTCP test invalid server", "[PutTCP]") {
@@ -368,10 +364,6 @@ TEST_CASE("PutTCP test invalid server", "[PutTCP]") {
   test_fixture.setPutTCPPort(1235);
   test_fixture.setHostname("localhost");
   trigger_expect_failure(test_fixture, "message for invalid server");
-
-  CHECK((LogTestController::getInstance().contains("Connection refused", 0ms)
-      || LogTestController::getInstance().contains("No connection could be made because the target machine actively refused it", 0ms)
-      || LogTestController::getInstance().contains("A connection attempt failed because the connected party did not properly respond", 0ms)));
 }
 
 TEST_CASE("PutTCP test non-routable server", "[PutTCP]") {
@@ -384,12 +376,6 @@ TEST_CASE("PutTCP test non-routable server", "[PutTCP]") {
   test_fixture.setHostname("192.168.255.255");
   test_fixture.setPutTCPPort(1235);
   trigger_expect_failure(test_fixture, "message for non-routable server");
-
-  CHECK((LogTestController::getInstance().contains("No route to host", 0ms)
-      || LogTestController::getInstance().contains("Connection timed out", 0ms)
-      || LogTestController::getInstance().contains("Operation timed out", 0ms)
-      || LogTestController::getInstance().contains("host has failed to respond", 0ms)
-      || LogTestController::getInstance().contains("No route to host", 0ms)));
 }
 
 TEST_CASE("PutTCP test invalid server cert", "[PutTCP]") {