You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "appletreeisyellow (via GitHub)" <gi...@apache.org> on 2023/05/01 18:13:36 UTC

[GitHub] [arrow-datafusion] appletreeisyellow opened a new pull request, #6185: chore(datetime_expression): support uppercase granularity for `DATE_TRUNC` func

appletreeisyellow opened a new pull request, #6185:
URL: https://github.com/apache/arrow-datafusion/pull/6185

   # Which issue does this PR close?
   
   Closes #6181.
   
   # Rationale for this change
   
   As [mentioned in an example](https://github.com/apache/arrow-datafusion/issues/6181#issuecomment-1529876740) in the original issue, `select date_trunc('year', time) from t` works, but `select date_trunc('YEAR', time) from t` doesn't work in `datafusion-cli`.
   
   # What changes are included in this PR?
   
   This PR fixes the bug to support uppercase granularities: `YEAR`, `QUARTER`, `MONTH`, `WEEK`, `DAY`, `HOUR`, `MINUTE`, and `SECOND`. 
   
   # Are these changes tested?
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   Yes, tests are added to cover the change in this PR
   
   # Are there any user-facing changes?
   
   Yes, an update to the doc is included in this PR
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] alamb commented on pull request #6185: chore(datetime_expression): support uppercase granularity for `DATE_TRUNC` func

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #6185:
URL: https://github.com/apache/arrow-datafusion/pull/6185#issuecomment-1530037621

   Looks great to me -- thank you @appletreeisyellow 
   
   I have started the CI for this PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-datafusion] jackwener merged pull request #6185: chore(datetime_expression): support uppercase granularity for `DATE_TRUNC` func

Posted by "jackwener (via GitHub)" <gi...@apache.org>.
jackwener merged PR #6185:
URL: https://github.com/apache/arrow-datafusion/pull/6185


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org