You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/06/03 07:11:43 UTC
[GitHub] [servicecomb-service-center] codecov-io edited a comment on issue
#549: [SCB-1307] Switch storage to etcd and add mock storage to tests
codecov-io edited a comment on issue #549: [SCB-1307] Switch storage to etcd and add mock storage to tests
URL: https://github.com/apache/servicecomb-service-center/pull/549#issuecomment-497636618
# [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/549?src=pr&el=h1) Report
> Merging [#549](https://codecov.io/gh/apache/servicecomb-service-center/pull/549?src=pr&el=desc) into [master](https://codecov.io/gh/apache/servicecomb-service-center/commit/1234288b5bf234b8d5584657dac29f7de36914dc?src=pr&el=desc) will **decrease** coverage by `0.13%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/servicecomb-service-center/pull/549?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #549 +/- ##
==========================================
- Coverage 58.65% 58.51% -0.14%
==========================================
Files 202 201 -1
Lines 15332 15261 -71
==========================================
- Hits 8993 8930 -63
+ Misses 5715 5711 -4
+ Partials 624 620 -4
```
| [Impacted Files](https://codecov.io/gh/apache/servicecomb-service-center/pull/549?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [syncer/servicecenter/sync.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/549/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvc3luYy5nbw==) | `69.38% <100%> (ø)` | :arrow_up: |
| [syncer/servicecenter/servicecenter.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/549/diff?src=pr&el=tree#diff-c3luY2VyL3NlcnZpY2VjZW50ZXIvc2VydmljZWNlbnRlci5nbw==) | `94.87% <100%> (ø)` | :arrow_up: |
| [syncer/pkg/ticker/ticker.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/549/diff?src=pr&el=tree#diff-c3luY2VyL3BrZy90aWNrZXIvdGlja2VyLmdv) | `80.95% <0%> (-19.05%)` | :arrow_down: |
| [server/notify/listwatcher.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/549/diff?src=pr&el=tree#diff-c2VydmVyL25vdGlmeS9saXN0d2F0Y2hlci5nbw==) | `69.44% <0%> (-9.73%)` | :arrow_down: |
| [pkg/util/tree.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/549/diff?src=pr&el=tree#diff-cGtnL3V0aWwvdHJlZS5nbw==) | `81.25% <0%> (-3.13%)` | :arrow_down: |
| [server/broker/util.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/549/diff?src=pr&el=tree#diff-c2VydmVyL2Jyb2tlci91dGlsLmdv) | `53.47% <0%> (+0.26%)` | :arrow_up: |
| [pkg/tlsutil/tlsutil.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/549/diff?src=pr&el=tree#diff-cGtnL3Rsc3V0aWwvdGxzdXRpbC5nbw==) | `74.52% <0%> (+0.94%)` | :arrow_up: |
| [...erver/plugin/pkg/tracing/buildin/file\_collector.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/549/diff?src=pr&el=tree#diff-c2VydmVyL3BsdWdpbi9wa2cvdHJhY2luZy9idWlsZGluL2ZpbGVfY29sbGVjdG9yLmdv) | `64.07% <0%> (+0.97%)` | :arrow_up: |
| [server/service/util/dependency.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/549/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2UvdXRpbC9kZXBlbmRlbmN5Lmdv) | `48.43% <0%> (+1.56%)` | :arrow_up: |
| [pkg/gopool/goroutines.go](https://codecov.io/gh/apache/servicecomb-service-center/pull/549/diff?src=pr&el=tree#diff-cGtnL2dvcG9vbC9nb3JvdXRpbmVzLmdv) | `100% <0%> (+2.63%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/549?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/servicecomb-service-center/pull/549?src=pr&el=footer). Last update [1234288...d2786c0](https://codecov.io/gh/apache/servicecomb-service-center/pull/549?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services