[GitHub] jglick commented on a change in pull request #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows

[GitBox <gi...@apache.org>]

jglick commented on a change in pull request #198: [SUREFIRE-1593] Correcting relativization logic to produce valid URIs on Windows
URL: https://github.com/apache/maven-surefire/pull/198#discussion_r232342689
 
 

 ##########
 File path: maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/JarManifestForkConfiguration.java
 ##########
 @@ -150,10 +150,9 @@ private static String toClasspathElementUri( @Nonnull Path parent,
     {
         try
         {
-            return new URI( null,
-                            parent.relativize( classPathElement.toPath() ).toString().
-                                replace( File.separatorChar, '/' ),
-                            null ).toASCIIString();
+            Path relativePath = parent.relativize( classPathElement.toPath() );
 
 Review comment:
   I cannot imagine you could write a reliable IT without Vagrant or similar.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services