[GitHub] [incubator-superset] etr2460 commented on a change in pull request #9054: [database] new, select star API migration

[GitBox <gi...@apache.org>]

etr2460 commented on a change in pull request #9054: [database] new, select star API migration
URL: https://github.com/apache/incubator-superset/pull/9054#discussion_r374251190
 
 

 ##########
 File path: superset/views/core.py
 ##########
 @@ -1958,11 +1958,26 @@ def extra_table_metadata(self, database_id, table_name, schema):
     @expose("/select_star/<database_id>/<table_name>/<schema>")
     @event_logger.log_this
     def select_star(self, database_id, table_name, schema=None):
-        mydb = db.session.query(models.Database).get(database_id)
+        logging.warning(
+            "This API endpoint is deprecated and will be removed in version 1.0.0"
 
 Review comment:
   one other thing that might be nice, is adding a statsd counter for each deprecated function, so that admins can easily check those counters to see if they're using any deprecated functions

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org