You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@gluten.apache.org by "zml1206 (via GitHub)" <gi...@apache.org> on 2024/04/26 05:33:29 UTC
[PR] [VL] Add config to force fallback for parquet timestamp type scan [incubator-gluten]
zml1206 opened a new pull request, #5546:
URL: https://github.com/apache/incubator-gluten/pull/5546
## What changes were proposed in this pull request?
Velox does not currently support read int64 timestamp in parquet files, so add config to force fallback for parquet timestamp type scan, default false.
## How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5547][VL] Add config to force fallback for parquet timestamp type scan [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5546:
URL: https://github.com/apache/incubator-gluten/pull/5546#issuecomment-2078718870
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5547][VL] Add config to force fallback for parquet timestamp type scan [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5546:
URL: https://github.com/apache/incubator-gluten/pull/5546#issuecomment-2078831458
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5547][VL] Add config to force fallback for parquet timestamp type scan [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5546:
URL: https://github.com/apache/incubator-gluten/pull/5546#issuecomment-2078673582
https://github.com/apache/incubator-gluten/issues/5547
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5547][VL] Add config to force fallback scan for timestamp type [incubator-gluten]
Posted by "GlutenPerfBot (via GitHub)" <gi...@apache.org>.
GlutenPerfBot commented on PR #5546:
URL: https://github.com/apache/incubator-gluten/pull/5546#issuecomment-2081218854
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
<table border="1" cellpadding="0" cellspacing="0">
<tbody>
<tr>
<td><font color=#000000>query</font></td>
<td><font color=#000000>log/native_master_04_27_2024_time.csv</font></td>
<td><font color=#000000>log/native_master_04_26_2024_0e4f87014_time.csv</font></td>
<td><font color=#000000>difference</font></td>
<td><font color=#000000>percentage</font></td>
</tr>
<tr>
<td><font color=#F92663>q1</font></td>
<td><font color=#F92663>36.70</font></td>
<td><font color=#F92663>38.73</font></td>
<td><font color=#F92663>2.027</font></td>
<td><font color=#F92663>105.52%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q2</font></td>
<td><font color=#6F9915>24.30</font></td>
<td><font color=#6F9915>23.98</font></td>
<td><font color=#6F9915>-0.312</font></td>
<td><font color=#6F9915>98.72%</font></td>
</tr>
<tr>
<td><font color=#F92663>q3</font></td>
<td><font color=#F92663>36.91</font></td>
<td><font color=#F92663>38.94</font></td>
<td><font color=#F92663>2.030</font></td>
<td><font color=#F92663>105.50%</font></td>
</tr>
<tr>
<td><font color=#F92663>q4</font></td>
<td><font color=#F92663>37.94</font></td>
<td><font color=#F92663>39.71</font></td>
<td><font color=#F92663>1.775</font></td>
<td><font color=#F92663>104.68%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q5</font></td>
<td><font color=#6F9915>67.99</font></td>
<td><font color=#6F9915>67.97</font></td>
<td><font color=#6F9915>-0.024</font></td>
<td><font color=#6F9915>99.97%</font></td>
</tr>
<tr>
<td><font color=#F92663>q6</font></td>
<td><font color=#F92663>5.73</font></td>
<td><font color=#F92663>7.12</font></td>
<td><font color=#F92663>1.388</font></td>
<td><font color=#F92663>124.22%</font></td>
</tr>
<tr>
<td><font color=#F92663>q7</font></td>
<td><font color=#F92663>81.54</font></td>
<td><font color=#F92663>83.76</font></td>
<td><font color=#F92663>2.216</font></td>
<td><font color=#F92663>102.72%</font></td>
</tr>
<tr>
<td><font color=#F92663>q8</font></td>
<td><font color=#F92663>85.59</font></td>
<td><font color=#F92663>87.47</font></td>
<td><font color=#F92663>1.882</font></td>
<td><font color=#F92663>102.20%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q9</font></td>
<td><font color=#6F9915>124.55</font></td>
<td><font color=#6F9915>124.47</font></td>
<td><font color=#6F9915>-0.084</font></td>
<td><font color=#6F9915>99.93%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q10</font></td>
<td><font color=#6F9915>47.35</font></td>
<td><font color=#6F9915>44.51</font></td>
<td><font color=#6F9915>-2.844</font></td>
<td><font color=#6F9915>93.99%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q11</font></td>
<td><font color=#6F9915>20.13</font></td>
<td><font color=#6F9915>20.06</font></td>
<td><font color=#6F9915>-0.069</font></td>
<td><font color=#6F9915>99.66%</font></td>
</tr>
<tr>
<td><font color=#F92663>q12</font></td>
<td><font color=#F92663>25.87</font></td>
<td><font color=#F92663>27.89</font></td>
<td><font color=#F92663>2.025</font></td>
<td><font color=#F92663>107.83%</font></td>
</tr>
<tr>
<td><font color=#F92663>q13</font></td>
<td><font color=#F92663>55.19</font></td>
<td><font color=#F92663>55.27</font></td>
<td><font color=#F92663>0.083</font></td>
<td><font color=#F92663>100.15%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q14</font></td>
<td><font color=#6F9915>17.66</font></td>
<td><font color=#6F9915>17.37</font></td>
<td><font color=#6F9915>-0.290</font></td>
<td><font color=#6F9915>98.36%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q15</font></td>
<td><font color=#6F9915>30.21</font></td>
<td><font color=#6F9915>29.90</font></td>
<td><font color=#6F9915>-0.311</font></td>
<td><font color=#6F9915>98.97%</font></td>
</tr>
<tr>
<td><font color=#F92663>q16</font></td>
<td><font color=#F92663>14.16</font></td>
<td><font color=#F92663>15.47</font></td>
<td><font color=#F92663>1.311</font></td>
<td><font color=#F92663>109.26%</font></td>
</tr>
<tr>
<td><font color=#F92663>q17</font></td>
<td><font color=#F92663>104.01</font></td>
<td><font color=#F92663>104.22</font></td>
<td><font color=#F92663>0.207</font></td>
<td><font color=#F92663>100.20%</font></td>
</tr>
<tr>
<td><font color=#F92663>q18</font></td>
<td><font color=#F92663>147.99</font></td>
<td><font color=#F92663>148.17</font></td>
<td><font color=#F92663>0.185</font></td>
<td><font color=#F92663>100.13%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q19</font></td>
<td><font color=#6F9915>14.61</font></td>
<td><font color=#6F9915>13.53</font></td>
<td><font color=#6F9915>-1.086</font></td>
<td><font color=#6F9915>92.57%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q20</font></td>
<td><font color=#6F9915>26.53</font></td>
<td><font color=#6F9915>25.97</font></td>
<td><font color=#6F9915>-0.558</font></td>
<td><font color=#6F9915>97.90%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q21</font></td>
<td><font color=#6F9915>288.59</font></td>
<td><font color=#6F9915>287.28</font></td>
<td><font color=#6F9915>-1.315</font></td>
<td><font color=#6F9915>99.54%</font></td>
</tr>
<tr>
<td><font color=#6F9915>q22</font></td>
<td><font color=#6F9915>14.78</font></td>
<td><font color=#6F9915>14.65</font></td>
<td><font color=#6F9915>-0.126</font></td>
<td><font color=#6F9915>99.14%</font></td>
</tr>
<tr>
<td><font color=#F92663>total</font></td>
<td><font color=#F92663>1308.33</font></td>
<td><font color=#F92663>1316.44</font></td>
<td><font color=#F92663>8.110</font></td>
<td><font color=#F92663>100.62%</font></td>
</tr>
</tbody>
</table>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add config to force fallback for parquet timestamp type scan [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5546:
URL: https://github.com/apache/incubator-gluten/pull/5546#issuecomment-2078663316
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICEGJ-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on Github Issues?
https://github.com/apache/incubator-gluten/issues
Then could you also rename ***commit message*** and ***pull request title*** in the following format?
[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}
See also:
* [Other pull requests](https://github.com/apache/incubator-gluten/pulls/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5547][VL] Add config to force fallback scan for timestamp type [incubator-gluten]
Posted by "Yohahaha (via GitHub)" <gi...@apache.org>.
Yohahaha merged PR #5546:
URL: https://github.com/apache/incubator-gluten/pull/5546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5547][VL] Add config to force fallback for parquet timestamp type scan [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5546:
URL: https://github.com/apache/incubator-gluten/pull/5546#issuecomment-2078718854
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [VL] Add config to force fallback for parquet timestamp type scan [incubator-gluten]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5546:
URL: https://github.com/apache/incubator-gluten/pull/5546#issuecomment-2078663511
Run Gluten Clickhouse CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5547][VL] Add config to force fallback scan for timestamp type [incubator-gluten]
Posted by "zhouyuan (via GitHub)" <gi...@apache.org>.
zhouyuan commented on PR #5546:
URL: https://github.com/apache/incubator-gluten/pull/5546#issuecomment-2081271077
CC @rui-mo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org
Re: [PR] [GLUTEN-5547][VL] Add config to force fallback scan for timestamp type [incubator-gluten]
Posted by "zml1206 (via GitHub)" <gi...@apache.org>.
zml1206 commented on PR #5546:
URL: https://github.com/apache/incubator-gluten/pull/5546#issuecomment-2080431260
Thank you for review. @Yohahaha
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@gluten.apache.org
For additional commands, e-mail: commits-help@gluten.apache.org