[GitHub] [iceberg] kbendick commented on a diff in pull request #4873: Core - Let TableMetadata be parsed from JSON without FileIO by deprecating FileIO in BaseSnapshot

[GitBox <gi...@apache.org>]

kbendick commented on code in PR #4873:
URL: https://github.com/apache/iceberg/pull/4873#discussion_r882159915


##########
core/src/main/java/org/apache/iceberg/BaseSnapshot.java:
##########
@@ -84,6 +89,25 @@ class BaseSnapshot implements Snapshot {
     this.manifestListLocation = manifestList;
   }
 
+  BaseSnapshot(long sequenceNumber,
+               long snapshotId,
+               Long parentId,
+               long timestampMillis,
+               String operation,
+               Map<String, String> summary,
+               Integer schemaId,
+               String manifestList) {
+    this.io = null;
+    this.sequenceNumber = sequenceNumber;
+    this.snapshotId = snapshotId;
+    this.parentId = parentId;
+    this.timestampMillis = timestampMillis;
+    this.operation = operation;
+    this.summary = summary;
+    this.schemaId = schemaId;
+    this.manifestListLocation = manifestList;
+  }

Review Comment:
   This constructor is not presently used. In most situations, it's ok to simply pass `null` as the FileIO.
   
   I didn't update the specific constructor used in an attempt to make this easier to cherry-pick.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org