You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@daffodil.apache.org by GitBox <gi...@apache.org> on 2022/12/08 17:21:03 UTC
[GitHub] [daffodil-vscode] scholarsmate opened a new pull request, #379: Prepare 1.3.0-SNAPSHOT builds
scholarsmate opened a new pull request, #379:
URL: https://github.com/apache/daffodil-vscode/pull/379
Prepare the repo for making 1.3.0 snapshot builds.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate merged pull request #379: Prepare 1.3.0-SNAPSHOT builds
Posted by GitBox <gi...@apache.org>.
scholarsmate merged PR #379:
URL: https://github.com/apache/daffodil-vscode/pull/379
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #379: Prepare 1.3.0-SNAPSHOT builds
Posted by GitBox <gi...@apache.org>.
scholarsmate commented on code in PR #379:
URL: https://github.com/apache/daffodil-vscode/pull/379#discussion_r1043635946
##########
package.json:
##########
@@ -2,7 +2,7 @@
"name": "apache-daffodil-vscode",
"displayName": "Apache Daffodil VS Code Extension",
"description": "VS Code extension for Apache Daffodil DFDL schema debugging",
- "version": "1.2.0-SNAPSHOT",
+ "version": "1.3.0-SNAPSHOT",
Review Comment:
It was properly set to 1.2.0 for the release. The issue was with merging this https://github.com/apache/daffodil-vscode/commit/3d98b6e17a20537325e5bb84b7c9d81225f80117. Once this PR is merged we'll be good again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] stevedlawrence commented on a diff in pull request #379: Prepare 1.3.0-SNAPSHOT builds
Posted by GitBox <gi...@apache.org>.
stevedlawrence commented on code in PR #379:
URL: https://github.com/apache/daffodil-vscode/pull/379#discussion_r1043628389
##########
package.json:
##########
@@ -2,7 +2,7 @@
"name": "apache-daffodil-vscode",
"displayName": "Apache Daffodil VS Code Extension",
"description": "VS Code extension for Apache Daffodil DFDL schema debugging",
- "version": "1.2.0-SNAPSHOT",
+ "version": "1.3.0-SNAPSHOT",
Review Comment:
Did we forget to remove the `-SNAPSHOT` from the 1.2.0 release? I thought the release candidate script checked for that and wouldn't allow a build?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [daffodil-vscode] scholarsmate commented on a diff in pull request #379: Prepare 1.3.0-SNAPSHOT builds
Posted by GitBox <gi...@apache.org>.
scholarsmate commented on code in PR #379:
URL: https://github.com/apache/daffodil-vscode/pull/379#discussion_r1043641391
##########
package.json:
##########
@@ -2,7 +2,7 @@
"name": "apache-daffodil-vscode",
"displayName": "Apache Daffodil VS Code Extension",
"description": "VS Code extension for Apache Daffodil DFDL schema debugging",
- "version": "1.2.0-SNAPSHOT",
+ "version": "1.3.0-SNAPSHOT",
Review Comment:
@Shanedell, can you give this PR a review? Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org