You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by bm...@apache.org on 2015/03/18 01:11:04 UTC

mesos git commit: Removed misleading comment getFieldID.

Repository: mesos
Updated Branches:
  refs/heads/master c9a1e0aee -> 0bedceb73


Removed misleading comment getFieldID.


Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/0bedceb7
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/0bedceb7
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/0bedceb7

Branch: refs/heads/master
Commit: 0bedceb73754334785eb0ae6ba63a6ccc641a5c6
Parents: c9a1e0a
Author: Benjamin Mahler <be...@gmail.com>
Authored: Tue Mar 17 17:10:52 2015 -0700
Committer: Benjamin Mahler <be...@gmail.com>
Committed: Tue Mar 17 17:10:52 2015 -0700

----------------------------------------------------------------------
 src/java/jni/convert.cpp | 3 ---
 1 file changed, 3 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/mesos/blob/0bedceb7/src/java/jni/convert.cpp
----------------------------------------------------------------------
diff --git a/src/java/jni/convert.cpp b/src/java/jni/convert.cpp
index de4a1a2..f1fcbcf 100644
--- a/src/java/jni/convert.cpp
+++ b/src/java/jni/convert.cpp
@@ -527,9 +527,6 @@ Result<jfieldID> getFieldID(
   if (jexception != NULL) {
     env->ExceptionClear(); // Clear the exception first before proceeding.
 
-    // NOTE: This was previously a static variable in order to only
-    // do the lookup once. But this is not thread-safe and led to
-    // crashes on Java 8!
     jclass noSuchFieldError = env->FindClass("java/lang/NoSuchFieldError");
     if (env->ExceptionCheck() == JNI_TRUE) {
       return Error("Cannot find NoSuchFieldError class");