Re: [PR] hrw4u: Fix u4wrh emitting quoted header names in HRW4U output [trafficserver]

["zwoop (via GitHub)" <gi...@apache.org>]

zwoop commented on PR #13207:
URL: https://github.com/apache/trafficserver/pull/13207#issuecomment-5517160161

   While looking at this, these fixes actually unravel another weakness in the u4wrh code. Look at this example below, it'd be good to address this here, since the fixes in this PR opens up potentially really bad results in some odd cases:
   
   ```
   leif@hel ~/apache/reviews/tools/hrw4u ±master⚡ » cat /tmp/foo.hrw
   cond %{SEND_RESPONSE_HDR_HOOK}
       set-header "body" "v"
   leif@hel ~/apache/reviews/tools/hrw4u ±master⚡ » uv run ./scripts/u4wrh /tmp/foo.hrw
   SEND_RESPONSE {
       inbound.resp.body = "v";
   }
   leif@hel ~/apache/reviews/tools/hrw4u ±master⚡ » uv run ./scripts/u4wrh /tmp/foo.hrw | uv run ./scripts/hrw4u
   cond %{SEND_RESPONSE_HDR_HOOK} [AND]
       set-body "v"
   ```
   
   This is specific to the body header, but I think it'd be good to address this here.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org