You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/10/30 21:10:02 UTC

[GitHub] [airflow] potiuk opened a new pull request, #27388: Remove image-tag in CI job names

potiuk opened a new pull request, #27388:
URL: https://github.com/apache/airflow/pull/27388

   Even simple last minute changes are sometimes bad. This one fixes IMAGE_TAG env which should not be used in job name.
   
   Fixes problem implemented in #27372
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   ---
   **^ Add meaningful description above**
   
   Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #27388: Remove image-tag in CI job names

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27388:
URL: https://github.com/apache/airflow/pull/27388#issuecomment-1296352039

   Last minute changes :( ... Tested it it with this PR https://github.com/potiuk/airflow/actions/runs/3357073728 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] ephraimbuddy commented on pull request #27388: Remove image-tag in CI job names

Posted by GitBox <gi...@apache.org>.
ephraimbuddy commented on PR #27388:
URL: https://github.com/apache/airflow/pull/27388#issuecomment-1296354540

   > Thks. And sorry for the hassle again :( .
   
   No worries. I was online :)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #27388: Remove image-tag in CI job names

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27388:
URL: https://github.com/apache/airflow/pull/27388#issuecomment-1296354468

   I am done with "build-image" changes for now .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk commented on pull request #27388: Remove image-tag in CI job names

Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #27388:
URL: https://github.com/apache/airflow/pull/27388#issuecomment-1296354414

   Thks. And sorry for the hassle again :( .


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [airflow] potiuk merged pull request #27388: Remove image-tag in CI job names

Posted by GitBox <gi...@apache.org>.
potiuk merged PR #27388:
URL: https://github.com/apache/airflow/pull/27388


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org