[jira] [Comment Edited] (MNG-7563) Java system properties now override user properties in dependencies

["Hervé Guillemet (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MNG-7563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616906#comment-17616906 ] 

Hervé Guillemet edited comment on MNG-7563 at 10/13/22 9:33 AM:
----------------------------------------------------------------

I tested with the commit just before the merge of this changeset, it worked, and with the commit of the changeset, it failed. 

Do you want me to try to revert the change set from the current head ?


was (Author: hg@apteryx.fr):
I tested with the commit just before the merge of this changeset, it worked, and with the commit of the changeset, it failed. 

Do you want me to try to revert the change set from the current master ?

> Java system properties now override user properties in dependencies
> -------------------------------------------------------------------
>
>                 Key: MNG-7563
>                 URL: https://issues.apache.org/jira/browse/MNG-7563
>             Project: Maven
>          Issue Type: Bug
>          Components: Dependencies, POM
>    Affects Versions: 3.8.5, 3.8.6
>            Reporter: Hervé Guillemet
>            Priority: Major
>         Attachments: poms.zip
>
>
> An important change has been introduced in 3.8.5 that breaks some existing builds: Java system properties now take precedence over default values of user properties in dependency POMs. This look like a bug since it's now easy to affect dependency behaviors with system properties, a practice that has been discouraged. But maybe do you consider this as a new feature ?
> As an example, 3 poms are attached to this ticket.
> After installing projects b and c, building project a with:
> {{mvn package -Ddep=x}}
> used to succeed until 3.8.4 (-D is ignored) but throws error with 3.8.5 and 3.8.6 (-D override the default).
> Note that without the setting of the default value for property {{dep}} in project b, the build fails with any version of Maven.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)