You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/03/02 17:10:01 UTC
svn commit: r1887096 -
/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java
Author: tilman
Date: Tue Mar 2 17:10:01 2021
New Revision: 1887096
URL: http://svn.apache.org/viewvc?rev=1887096&view=rev
Log:
PDFBOX-4892: adjust type + remove unneeded code + set initial ArrayList size, as suggested by valerybokov
Modified:
pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java
Modified: pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java?rev=1887096&r1=1887095&r2=1887096&view=diff
==============================================================================
--- pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java (original)
+++ pdfbox/trunk/pdfbox/src/main/java/org/apache/pdfbox/cos/COSArray.java Tue Mar 2 17:10:01 2021
@@ -202,7 +202,7 @@ public class COSArray extends COSBase im
*/
public COSBase getObject( int index )
{
- Object obj = objects.get( index );
+ COSBase obj = objects.get( index );
if( obj instanceof COSObject )
{
obj = ((COSObject)obj).getObject();
@@ -211,7 +211,7 @@ public class COSArray extends COSBase im
{
obj = null;
}
- return (COSBase)obj;
+ return obj;
}
/**
@@ -473,7 +473,7 @@ public class COSArray extends COSBase im
public int indexOfObject(COSBase object)
{
int retval = -1;
- for (int i = 0; retval < 0 && i < this.size(); i++)
+ for (int i = 0; i < this.size(); i++)
{
COSBase item = this.get(i);
if (item.equals(object) ||
@@ -622,7 +622,7 @@ public class COSArray extends COSBase im
*/
public List<Float> toCOSNumberFloatList()
{
- List<Float> numbers = new ArrayList<>();
+ List<Float> numbers = new ArrayList<>(size());
for (int i = 0; i < size(); i++)
{
COSBase num = getObject(i);
@@ -645,7 +645,7 @@ public class COSArray extends COSBase im
*/
public List<Integer> toCOSNumberIntegerList()
{
- List<Integer> numbers = new ArrayList<>();
+ List<Integer> numbers = new ArrayList<>(size());
for (int i = 0; i < size(); i++)
{
COSBase num = getObject(i);