You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2024/03/24 11:53:42 UTC

[PR] fix evaluation in nightly-builds.yml [pekko]

pjfanning opened a new pull request, #1234:
URL: https://github.com/apache/pekko/pull/1234

   bug in #1231 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] fix evaluation in nightly-builds.yml [pekko]

Posted by "He-Pin (via GitHub)" <gi...@apache.org>.
He-Pin commented on code in PR #1234:
URL: https://github.com/apache/pekko/pull/1234#discussion_r1536797751


##########
.github/workflows/nightly-builds.yml:
##########
@@ -172,7 +172,7 @@ jobs:
           sudo apt-get install graphviz
           # genjavadoc does not support Scala 3.x
           sbt \
-            -Dpekko.genjavadoc.enabled={{ matrix.scalaVersion != '3.3' }} \
+            -Dpekko.genjavadoc.enabled=${{ matrix.scalaVersion != '3.3' }} \

Review Comment:
   https://docs.github.com/en/actions/learn-github-actions/expressions#example
   Nice.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org


Re: [PR] fix evaluation in nightly-builds.yml [pekko]

Posted by "pjfanning (via GitHub)" <gi...@apache.org>.
pjfanning merged PR #1234:
URL: https://github.com/apache/pekko/pull/1234


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org