You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/13 08:23:20 UTC
[GitHub] [incubator-shardingsphere] KomachiSion opened a new pull request
#5161: Extract datasource check to ShardingScalingJobPreparer
KomachiSion opened a new pull request #5161: Extract datasource check to ShardingScalingJobPreparer
URL: https://github.com/apache/incubator-shardingsphere/pull/5161
For #5106 .
Changes proposed in this pull request:
- Extract datasource check to ShardingScalingJobPreparer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5161:
Extract datasource check to ShardingScalingJobPreparer
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5161: Extract datasource check to ShardingScalingJobPreparer
URL: https://github.com/apache/incubator-shardingsphere/pull/5161#issuecomment-612817209
## Pull Request Test Coverage Report for [Build 10996](https://coveralls.io/builds/30033639)
* **0** of **20** **(0.0%)** changed or added relevant lines in **3** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.06%**) to **57.595%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/controller/task/SyncTaskControlStatus.java](https://coveralls.io/builds/30033639/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fcontroller%2Ftask%2FSyncTaskControlStatus.java#L58) | 0 | 1 | 0.0%
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/controller/ScalingJobController.java](https://coveralls.io/builds/30033639/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fcontroller%2FScalingJobController.java#L41) | 0 | 5 | 0.0%
| [sharding-scaling/sharding-scaling-core/src/main/java/org/apache/shardingsphere/shardingscaling/core/preparer/ShardingScalingJobPreparer.java](https://coveralls.io/builds/30033639/source?filename=sharding-scaling%2Fsharding-scaling-core%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingscaling%2Fcore%2Fpreparer%2FShardingScalingJobPreparer.java#L31) | 0 | 14 | 0.0%
<!-- | **Total:** | **0** | **20** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/30033639) |
| :-- | --: |
| Change from base [Build 10995](https://coveralls.io/builds/30030468): | -0.06% |
| Covered Lines: | 11811 |
| Relevant Lines: | 20507 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #5161:
Extract datasource check to ShardingScalingJobPreparer
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #5161: Extract datasource check to ShardingScalingJobPreparer
URL: https://github.com/apache/incubator-shardingsphere/pull/5161
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services