You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2023/08/03 12:58:00 UTC
[jira] [Commented] (IMPALA-12049) test_drop_corrupt_table is flaky, fails with "No failure encountered for query"
[ https://issues.apache.org/jira/browse/IMPALA-12049?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17750738#comment-17750738 ]
ASF subversion and git services commented on IMPALA-12049:
----------------------------------------------------------
Commit 7a02b3b276a803cededd726abcc0aa0fd114e198 in impala's branch refs/heads/master from Andrew Sherman
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=7a02b3b27 ]
IMPALA-12049: Deflake test_drop_corrupt_table
Originally there were two flavors of the test_drop_corrupt_table test.
One version (test_drop_corrupt_table_with_invalidate) did
an 'invalidate metadata' as part of the test after deleting metadata
files, and the other version did not. The version without invalidation
was depending on the catalog update resulting from adding the iceberg
table arriving at the coordinator before the deletion. This happens a
lot of the time but it can't be guaranteed. Fix the test by removing
test_drop_corrupt_table. Simplify the code a little by inlining a
method, and rename the remaining test to be test_drop_corrupt_table.
Change-Id: I4cbdf5646ed20bb8333e5557ed43226de993b7dd
Reviewed-on: http://gerrit.cloudera.org:8080/20289
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
> test_drop_corrupt_table is flaky, fails with "No failure encountered for query"
> -------------------------------------------------------------------------------
>
> Key: IMPALA-12049
> URL: https://issues.apache.org/jira/browse/IMPALA-12049
> Project: IMPALA
> Issue Type: Bug
> Affects Versions: Impala 4.3.0
> Reporter: Andrew Sherman
> Assignee: Andrew Sherman
> Priority: Critical
>
> On an Ozone build this test failed. Looks like test is flaky.
> {code}
> Error Message
> query_test/test_iceberg.py:149: in test_drop_corrupt_table self._do_test_drop_corrupt_table(unique_database, do_invalidate=False) query_test/test_iceberg.py:175: in _do_test_drop_corrupt_table format(full_table_name)) common/impala_test_suite.py:929: in wrapper return function(*args, **kwargs) common/impala_test_suite.py:952: in execute_query_expect_failure assert not result.success, "No failure encountered for query %s" % query E AssertionError: No failure encountered for query select * from test_drop_corrupt_table_fb61cd07.corrupt_iceberg_tbl
> {code}
> {code}
> Stacktrace
> query_test/test_iceberg.py:149: in test_drop_corrupt_table
> self._do_test_drop_corrupt_table(unique_database, do_invalidate=False)
> query_test/test_iceberg.py:175: in _do_test_drop_corrupt_table
> format(full_table_name))
> common/impala_test_suite.py:929: in wrapper
> return function(*args, **kwargs)
> common/impala_test_suite.py:952: in execute_query_expect_failure
> assert not result.success, "No failure encountered for query %s" % query
> E AssertionError: No failure encountered for query select * from test_drop_corrupt_table_fb61cd07.corrupt_iceberg_tbl
> {code}
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org